This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
Use the Error interface from the CDK DA repo
#49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goran-ethernal
approved these changes
Jan 23, 2024
|
Stefan-Ethernal
changed the title
Error interfaceError interface from the CDK DA repo
Stefan-Ethernal
deleted the
fix/use-correct-rpc-error-for-interop-funcs
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns function signature for interop functions so that it conforms to the expected signature, where second return value must be of type
rpc.Errorfrom the cdk-data-availability repo (https://github.com/0xPolygon/cdk-data-availability/blob/10cc1631e5a67761e655d9cbd3a9e3016fb3f757/rpc/error.go#L33-L37), instead the one used from the zk-evm-node repo (https://github.com/0xPolygonHermez/zkevm-node/blob/76e3118a9bc70b261b3c67d01fa9fcf7be3712de/jsonrpc/types/errors.go#L31-L35).The panic was caused by this check, which was failing https://github.com/0xPolygon/cdk-data-availability/blob/10cc1631e5a67761e655d9cbd3a9e3016fb3f757/rpc/handler.go#L256-L259.