Skip to content

Add tests showing code that fails in 1.5 that worked in 1.4 #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add tests showing code that fails in 1.5 that worked in 1.4 #675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions types/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,4 +251,21 @@ function* mySaga(): Effects.SagaGenerator<void> {
yield* Effects.spawn([obj, "outer"], emitter, handler);
yield* Effects.spawn({ context: obj, fn: obj.outer }, emitter, handler);
yield* Effects.spawn({ context: obj, fn: "outer" }, emitter, handler);

// eslint-disable-next-line @typescript-eslint/no-unused-vars
function handleArgumentThatIsPartOfUnion(requestId: 27 | 28) {
return 22;
}
// $ExpectType number
yield* Effects.call(handleArgumentThatIsPartOfUnion, 27);

type FetchOptions = {
readonly method?: "GET" | "POST";
};
// eslint-disable-next-line @typescript-eslint/no-unused-vars
function* ourFetch(options: FetchOptions) {}
// Fails in 1.5 as argument is widened to string it seems (works in 1.4)
yield* Effects.call(ourFetch, { method: "POST" });
// Works (in 1.5 and 1.4, but this workaround is not possible for the numeric case above)
yield* Effects.call(ourFetch, { method: "POST" as const });
}