Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CMake #2

Merged
merged 5 commits into from
Feb 9, 2024
Merged

update CMake #2

merged 5 commits into from
Feb 9, 2024

Conversation

nim65s
Copy link
Contributor

@nim65s nim65s commented Feb 2, 2024

  • use CMake to get M3T instead of git submodule
  • use CMake to get pybind11 instead of pip
  • use option() for kinect / realsense / gtest, to allow eg. cmake -DUSE_REALSENSE=ON or cmake -DUSE_REALSENSE=OFF
  • remove CMAKE_CXX_STANDARD: we want at least 17, so don't require exactly 17. use cxx_std_17 instead, ref. https://cmake.org/cmake/help/latest/manual/cmake-compile-features.7.html#requiring-language-standards
  • remove CMAKE_BUILD_TYPE to allow users specify themselves eg. cmake -DCMAKE_BUILD_TYPE=Debug or export CMAKE_BUILD_TYPE=RelWithDebInfo
  • remove -fPIC, as it looks like it is not necessary.

A better solution would be to make CMake look for M3T & pybind11, and fetch those only if they are not found. It would allow downstream package managers to provide their own versions and avoid dynamic downloads at configure time.

@nim65s nim65s merged commit c170be6 into agimus-project:master Feb 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant