Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
option()
for kinect / realsense / gtest, to allow eg.cmake -DUSE_REALSENSE=ON
orcmake -DUSE_REALSENSE=OFF
CMAKE_CXX_STANDARD
: we want at least 17, so don't require exactly 17. usecxx_std_17
instead, ref. https://cmake.org/cmake/help/latest/manual/cmake-compile-features.7.html#requiring-language-standardsCMAKE_BUILD_TYPE
to allow users specify themselves eg.cmake -DCMAKE_BUILD_TYPE=Debug
orexport CMAKE_BUILD_TYPE=RelWithDebInfo
-fPIC
, as it looks like it is not necessary.A better solution would be to make CMake look for M3T & pybind11, and fetch those only if they are not found. It would allow downstream package managers to provide their own versions and avoid dynamic downloads at configure time.