-
-
Notifications
You must be signed in to change notification settings - Fork 48
Complete French translation for configuration interface #686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
foXaCe
wants to merge
22
commits into
agittins:main
Choose a base branch
from
foXaCe:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing French translations for configuration options, calibration steps, and error messages.
Use localization system for status messages instead of hardcoded strings.
The previous approach using self.hass.localize() was causing errors. These dynamic messages in description_placeholders cannot be easily localized with the standard Home Assistant translation system.
- Add search/filter field to find devices by name, MAC address or manufacturer - Group devices by type (iBeacon, standard BLE, random MAC) with separate selectors - Implement pagination (50 devices per category) with automatic filtering bypass - Display device counts and helpful search tips - Add manufacturer and RSSI information to device labels for better identification - Include full French and English translations This makes device selection much easier when dealing with large numbers of Bluetooth devices, especially useful for finding specific Tile trackers or other devices by manufacturer name.
- Fix E501: Split long line in iBeacon label to stay within 120 char limit - Fix N806: Change MAX_DEVICES_PER_CATEGORY to lowercase max_devices_per_category
The search filter was not working because the form submission logic was incorrectly detecting filter-only submissions as device selections. Changes: - Fixed condition to check for actual device selections (non-empty lists) instead of just checking if selector fields exist in user_input - Added debug logging to track filter and selection behavior - Updated UI text to clarify that users need to click Submit to apply filters - Added visual feedback showing active filter text - Updated both English and French translations The search now works correctly: 1. User types search term and clicks Submit → form re-renders with filtered devices 2. User selects devices and clicks Submit → saves selection and exits 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add detailed logging to understand how service UUIDs are being processed and why Tile devices (UUID 0xFEED) may not be recognized properly. This will help diagnose: - The exact format of UUIDs received from BLE advertisements - Whether the UUID extraction logic (uuid[4:8]) is working correctly - If the manufacturer lookup is finding Tile, Inc. in the database 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
CRITICAL fixes: - util.py: rssi_to_metres() now returns None instead of False for missing params - bermuda_device.py: fixed bitwise operations for MAC address type detection (0b00 AND always returns 0, changed to proper equality checks) HIGH fixes: - coordinator.py: fixed incorrect `val is any([...])` to `val in (...)` - __init__.py: fixed _LOGGER.exception() usage (auto-captures exception) - coordinator.py: simplified redundant `is ... or ==` to just `==` MEDIUM fixes: - const.py: added BDADDR_TYPE_RANDOM_RESERVED constant - pyproject.toml: removed obsolete ANN101 rule - const.py: removed invalid RUF028 suppression comments Also fixed multiple spelling errors in comments
CRITICAL fixes: - bermuda_device.py:445: floor_level self-assignment bug (was no-op) Changed `self.floor_level = self.floor_level` to `self.floor_level = self.floor.level` MEDIUM fixes: - coordinator.py:1035-1043: added early return after validation errors to prevent invalid devices from proceeding - coordinator.py:883: fixed off-by-one pruning error using cutoff_index properly (was pruning one fewer device than needed) - sensor.py:275: unguarded dict access now uses .get() with None check - sensor.py:363-366: scanner device lookup now validates and raises KeyError - bermuda_irk.py:141: added early return when cipher is None LOW fixes: - coordinator.py:1491: removed unused type annotation line - coordinator.py:15/99: moved BaseHaScanner import to TYPE_CHECKING block
When a device is not detected (out of BLE range), area-related sensors now return "not_home" instead of "unknown" for consistency with device_tracker behavior. This fixes two issues: 1. Blueprints no longer need to explicitly handle "unknown" as absent 2. HA restarts no longer trigger false arrivals (unknown -> area) Affected sensors: - sensor.*_area: returns "not_home" when area_name is None - sensor.*_floor: returns "not_home" when floor_name is None - sensor.*_scanner: returns "not_home" when no scanner detected
- Add Debouncer to coordinator for request refresh throttling - Add py.typed marker for strict typing (PEP 561)
- Add loggers field to manifest.json (Bronze requirement) - Add selectors to services.yaml fields for better UI - Improve service description
Replace TODO/FIXME markers with descriptive comments: - bermuda_irk.py: Document bleak version compatibility - config_flow.py: Clarify HTML placeholder workaround - coordinator.py: Document design decisions and known limitations - sensor.py: Simplify icon property comment No functional changes - documentation only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing French translations for configuration options, calibration steps, and error messages.