Fix ValueError when processing device identifiers with 3+ elements #727
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a ValueError that occurs when processing device registry updates for devices with identifiers containing more than 2 elements (e.g., HomeKit devices use 3-element identifiers).
Problem
The current code assumes all device identifiers are 2-tuples
(domain, id), but some integrations like HomeKit use 3-element identifiers(domain, id, type). This causesValueError: too many values to unpack (expected 2)when those devices trigger registry updates.Solution
Changed the unpacking to iterate over identifiers and safely extract the first two elements regardless of total length.
Before
After