Leaf Node Locatable #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds location-fetching methods to LeafNode, allowing you to click through from a node selection to the source location in VS Code. Adds CodeQL classes for File, Folder, Location, and Locatable, all basically ripped from the JS CodeQL library. Also adds a CodeQL tests/ dir which can be run using `codeql test run ql/test` , and added that to the CI suite. This may replace the existing e2e CodeQL runner currently in Ruby, following [PoLA](https://en.wikipedia.org/wiki/Principle_of_least_astonishment) for CodeQL development. See [Semmle help documentation](https://help.semmle.com/codeql/codeql-cli/procedures/test-queries.html) on testing CodeQL custom queries and libraries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #3 ran aground on getting
codeql test runworking in Github Actions, this PR trims that out and sticks with therspec-based extractor tests. Otherwise cherry-picks out the commits from there.codeql test runwill have to be its own PR.