Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with telemetry being overwritten #2170

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

dirkbrnd
Copy link
Contributor

Description

Users experienced issues where telemetry would be sent regardless of whether they set the telemetry flag or not.


Type of change

Please check the options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Model update (Addition or modification of models)
  • Other (please describe):

Checklist

  • Adherence to standards: Code complies with Agno’s style guidelines and best practices.
  • Formatting and validation: You have run ./scripts/format.sh and ./scripts/validate.sh to ensure code is formatted and linted.
  • Self-review completed: A thorough review has been performed by the contributor(s).
  • Documentation: Docstrings and comments have been added or updated for any complex logic.
  • Examples and guides: Relevant cookbook examples have been included or updated (if applicable).
  • Tested in a clean environment: Changes have been tested in a clean environment to confirm expected behavior.
  • Tests (optional): Tests have been added or updated to cover any new or changed functionality.

Additional Notes

Include any deployment notes, performance implications, security considerations, or other relevant information (e.g., screenshots or logs if applicable).

@dirkbrnd dirkbrnd requested a review from a team as a code owner February 18, 2025 13:18
@andrew-stelmach
Copy link

LGTM

@kiorq
Copy link

kiorq commented Feb 18, 2025

LGTM, thanks @dirkbrnd

@willemcdejongh willemcdejongh merged commit eaaac4c into main Feb 19, 2025
2 checks passed
@willemcdejongh willemcdejongh deleted the fix-telemetry-defaults branch February 19, 2025 04:57
@dirkbrnd
Copy link
Contributor Author

LGTM

LGTM, thanks @dirkbrnd

Lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants