Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump the major-dependencies group with 2 updates #413

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 6, 2023

Bumps the major-dependencies group with 2 updates: bootstrap and firebase.

Updates bootstrap from 4.6.2 to 5.3.2

Release notes

Sourced from bootstrap's releases.

v5.3.2

Highlights

  • Passing a percentage unit to the global abs() is deprecated since Dart Sass v1.65.0. It resulted in a deprecation warning when compiling Bootstrap with Dart Sass. This has been fixed internally by changing the values passed to the divide() function. The divide() function has not been fixed itself so that we can keep supporting node-sass cross-compatibility. In v6, this won't be an issue as we plan to drop support for node-sass.
  • Using multiple ids in a collapse target wasn't working anymore and has been fixed.

Color modes

  • Increased color contrast of form range track background in light and dark modes.
  • Fixed table state rendering for color modes with a focus on the striped table in dark mode to increase color contrast.
  • Allow <mark> color customization for color modes.

Docs


🎨 CSS

  • #38816: Use box-shadow CSS variables shadow utilities
  • #38955: Fix radios looking like ellipse on responsive mode
  • #38976: Use box-shadow CSS vars instead of Sass vars in assets and variables
  • #39030: Fix dart-sass deprecation warning
  • #39033: Color mode: fix table state rendering
  • #39095: Make form range track background more contrasted
  • #39119: New Sass var $btn-link-focus-shadow-rgb to allow customization
  • #39141: New Sass variable to handle <mark> dark mode bg color

☕️ JavaScript

  • #38989: Collapse: Fix multiple ids calls
  • #39046: Dropdown: reuse variable

📖 Docs

  • #38873: Discord reddit bootstrap
  • #38970: docs: add BootstrapVueNext to docs
  • #38977: Docs: Add missing form elements in focusable elements
  • #38978: Docs: Fix popover template role error
  • #38995: introduction: drop details element
  • #39037: Further improve image compression with oxipng and the latest jpegoptim
  • #39054: Docs: Remove incorrect mention of .left- and .right- utilities from migration guide
  • #39060: Migration: add back v5.0.0 heading
  • #39145: Docs: add warning callout to add a workaround when jsDelivr is not available
  • #39177: Fix: make theme selector tick icon visible when active in examples layout
  • #39179: download: Reword CDN paragraph

... (truncated)

Commits

Updates firebase from 9.23.0 to 10.4.0

Commits
  • 3337f59 Version Packages (#7626)
  • aa0f8a9 Merge master into release
  • 98cfcbd Firestore: Increase test coverage for persistent cache indexing (#7613)
  • 320e58c Firestore: Set DEFAULT_RELATIVE_INDEX_READ_COST_PER_DOCUMENT to 8 in query_en...
  • fbd8e0e Firestore: Release enablePersistentCacheIndexAutoCreation() and related funct...
  • c5b9b1f Firestore: Move local store index auto-creation unit tests into the proper fi...
  • 74fc4cf Add test cases for existence filter with updated/added documents (#7457)
  • 2d0a9f5 Update some minor dependencies. (#7592)
  • 1fd9d25 Version Packages (#7595) (#7600)
  • 60e4a07 Fix webchannel wrapper overrides (#7593)
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 6, 2023
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/major-dependencies-ec8cb75c6e branch from 9b8a100 to 56e41cc Compare October 6, 2023 20:46
Copy link
Member

@steveoh steveoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should bootstrap be ignored completely?
firebase has to wait until react fire updates refs FirebaseExtended/reactfire#594

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/major-dependencies-ec8cb75c6e branch from 56e41cc to f1b335e Compare October 12, 2023 18:14
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/major-dependencies-ec8cb75c6e branch from f1b335e to a008655 Compare October 12, 2023 18:31
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/major-dependencies-ec8cb75c6e branch from a008655 to 22db199 Compare October 12, 2023 18:55
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/major-dependencies-ec8cb75c6e branch from 22db199 to 0f25bbd Compare October 12, 2023 18:56
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/major-dependencies-ec8cb75c6e branch from 0f25bbd to 68bca8b Compare October 12, 2023 18:58
@stdavis
Copy link
Member

stdavis commented Oct 12, 2023

should bootstrap be ignored completely?

I think so. It's hard for me to justify spending time upgrading it when it should really be converted the utah design system.

@dependabot ignore bootstrap major

Bumps the major-dependencies group with 2 updates: [bootstrap](https://github.com/twbs/bootstrap) and [firebase](https://github.com/firebase/firebase-js-sdk).


Updates `bootstrap` from 4.6.2 to 5.3.2
- [Release notes](https://github.com/twbs/bootstrap/releases)
- [Commits](twbs/bootstrap@v4.6.2...v5.3.2)

Updates `firebase` from 9.23.0 to 10.4.0
- [Release notes](https://github.com/firebase/firebase-js-sdk/releases)
- [Changelog](https://github.com/firebase/firebase-js-sdk/blob/master/CHANGELOG.md)
- [Commits](https://github.com/firebase/firebase-js-sdk/compare/firebase@9.23.0...firebase@10.4.0)

---
updated-dependencies:
- dependency-name: bootstrap
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: major-dependencies
- dependency-name: firebase
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: major-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
@steveoh steveoh force-pushed the dependabot/npm_and_yarn/major-dependencies-ec8cb75c6e branch from 68bca8b to 20e92f3 Compare October 13, 2023 19:18
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 13, 2023

Looks like these dependencies are updatable in another way, so this is no longer needed.

@dependabot dependabot bot closed this Oct 13, 2023
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/major-dependencies-ec8cb75c6e branch October 13, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants