Modernize

.coveragerc

@@ -1,14 +1,8 @@
 [report]
-skip_covered = True
-show_missing = True
-precision = 2
 exclude_lines =
-  def __repr__
-  continue
-  raise NotImplementedError
-  if __name__ == .__main__.:
-  log
-  print
+    # Don't complain if non-runnable code isn't run:
+    if __name__ == .__main__.
+
 [run]
 omit =
-  src/forklift/__main__.py
+    src/forklift/__main__.py

.editorconfig

@@ -0,0 +1,10 @@
+root = true
+
+[*.py]
+indent_size = 4
+
+[*]
+indent_style = space
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true

.git-blame-ignore-revs

@@ -0,0 +1 @@
+51699f13b5e9044cfde4b43811900e8557f1db7f

.github/dependabot.yml

@@ -0,0 +1,21 @@
+version: 2
+updates:
+  - package-ecosystem: pip
+    directory: /
+    schedule:
+      interval: monthly
+    groups:
+      safe-dependencies:
+        update-types: ["minor", "patch"]
+      major-dependencies:
+        update-types: ["major"]
+    commit-message:
+      prefix: deps
+      prefix-development: deps(dev)
+  - package-ecosystem: github-actions
+    directory: /
+    schedule:
+      interval: monthly
+    groups:
+      ci-dependencies:
+        dependency-type: "production"

.github/workflows/pull_request.yml

@@ -0,0 +1,44 @@
+name: Pull Request Events
+
+on:
+  pull_request:
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.head_ref || github.ref }}
+  cancel-in-progress: true
+
+permissions: {}
+
+jobs:
+  test-unit:
+    name: Unit Tests
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: ⬇️ Set up code
+        uses: actions/checkout@v4
+        with:
+          show-progress: false
+
+      - name: 🐍 Set up Python
+        uses: actions/setup-python@v5
+        with:
+          cache: pip
+          cache-dependency-path: setup.py
+
+      - name: 📥 Install arcgis dependencies
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y libkrb5-dev
+
+      - name: 🏗 Install module
+        run: pip install .[tests]
+
+      - name: 🧶 Lint
+        run: ruff check --output-format=github .
+
+      - name: ⬆️ Upload coverage to Codecov
+        uses: codecov/codecov-action@v4
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+          file: ./cov.xml

.github/workflows/push.yml

@@ -0,0 +1,66 @@
+name: Push Events
+
+on:
+  push:
+    branches:
+      - main
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  release-please:
+    name: Create release
+    runs-on: ubuntu-latest
+    permissions:
+      contents: write
+      pull-requests: write
+    outputs:
+      release_created: ${{ steps.release-please.outputs.release_created }}
+
+    steps:
+      - name: 🚀 Create Release
+        id: release-please
+        uses: agrc/release-composite-action@v1
+        with:
+          release-type: python
+          prerelease: ${{ github.ref_name == 'dev' }}
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+          github-app-id: ${{ secrets.UGRC_RELEASE_BOT_APP_ID }}
+          github-app-key: ${{ secrets.UGRC_RELEASE_BOT_APP_KEY }}
+          github-app-name: ${{ secrets.UGRC_RELEASE_BOT_NAME }}
+          github-app-email: ${{ secrets.UGRC_RELEASE_BOT_EMAIL }}
+
+  upload-coverage:
+    name: Upload coverage
+    runs-on: ubuntu-latest
+    needs: release-please
+    if: needs.release-please.outputs.release_created
+
+    steps:
+      - name: ⬇️ Set up code
+        uses: actions/checkout@v4
+        with:
+          show-progress: false
+
+      - name: 🐍 Set up Python
+        uses: actions/setup-python@v5
+        with:
+          cache: pip
+          cache-dependency-path: setup.py
+
+      - name: 🏗 Install module
+        run: pip install .[tests]
+
+      - name: ⚙️ Add config file
+        run: cp config.sample.json config.json
+
+      - name: 🧪 Run tests
+        run: pytest
+
+      - name: ⬆️ Upload coverage to Codecov
+        uses: codecov/codecov-action@v4
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+          file: ./cov.xml

.gitignore

@@ -30,6 +30,7 @@ pip-log.txt
 nosetests.xml
 htmlcov
 .noseids
+cov.xml
 
 .DS_Store
 *~

.python-version

@@ -0,0 +1 @@
+3.9

LICENSE

@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) UGRC
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

readme.md → README.md

@@ -100,7 +100,7 @@ From within the [ArcGIS Pro conda environment](http://pro.arcgis.com/en/pro-app/
 1. Create a conda environment for forklift `conda create --name forklift python=3.9`.
 1. Activate the conda environment `activate forklift`.
 1. `conda install arcpy -c esri`
-1. Chckout forklift repository: `git clone https://github.com/agrc/forklift.git` 
+1. Checkout forklift repository: `git clone https://github.com/agrc/forklift.git`
 1. `pip install .\` from the directory containing `setup.py`.
 1. Install the python dependencies for your pallets.
 1. `forklift config init`
@@ -190,29 +190,19 @@ If you do need to recreate the forklift environment from scratch, follow these s
 - create new env
   - `conda create --name forklift --clone arcgispro-py3`
   - `activate forklift`
-- install deps
-  - conda or pip install everything in the `setup.py` `install_requires`
-- optionally install forklift
-  - `cd forklift`
-  - `pip install .\ -U`
+- install forklift and deps
+  - `pip install -e ".[tests]"`
 - run forklift
-  - for the installed version execute `forklift -h`
-  - for the source version, from the `**/src**` directory, execute `python -m forklift -h` for usage
+  - `forklift -h`
 
 ### Tests
 
-#### On first run
+Tests should show up in VSCode's text explorer.
 
-- install deps
-  - `pip install -e ".[tests]"`
-- run tests
-  - `python setup.py develop`
-  - `pytest -p no:faulthandler`
+To run them from the command line:
 
-`-p no:faulthandler` is to [prevent pytest from printing _tons_ of errors](https://stackoverflow.com/a/65826036/8049053).
+- `pytest`
 
 _Tests that depend on a local SDE database (see `tests/data/UPDATE_TESTS.bak`) will automatically be skipped if it is not found on your system._
 
 To run a specific test or suite: `pytest -k <test/suite name>`
-
-If you have pip installed forklift into your current environment, you may need to uninstall it to get tests to see recent updates to the source code.

pyproject.toml

@@ -0,0 +1,12 @@
+[tool.ruff]
+line-length = 120
+extend-exclude = ["*/PalletWithSyntaxErrors.py"]
+[tool.ruff.lint]
+ignore = ["E501"]
+[tool.pytest.ini_options]
+minversion = "6.0"
+testpaths = ["tests", "src"]
+norecursedirs = [".env", "data", ".github", ".vscode"]
+console_output_style = "count"
+addopts = "--cov-branch --cov=forklift --cov-report term --cov-report xml:cov.xml --instafail -p no:faulthandler"
+# `-p no:faulthandler` is to [prevent pytest from printing _tons_ of errors](https://stackoverflow.com/a/65826036/8049053).

samples/ChangeDetectionPallet.py

@@ -1,12 +1,13 @@
 #!/usr/bin/env python
 # * coding: utf8 *
-'''
+"""
 ChangeDetectionPallet.py
 A module containing an sample of a pallet that uses change detection.j
 
 Note: In order for this pallet to use change detection, the `changeDetectionTables` config prop needs to
 have `UPDATE_TESTS.sde\\ChangeDetection` in it's array.
-'''
+"""
+
 from os.path import join
 
 import arcpy
@@ -15,4 +16,4 @@
 
 class ChangeDetectionPallet(Pallet):
     def build(self, configuration):
-        self.add_crate(('ChangeDetectionPallet', join(self.garage, 'UPDATE_TESTS.sde'), arcpy.env.scratchGDB))
+        self.add_crate(("ChangeDetectionPallet", join(self.garage, "UPDATE_TESTS.sde"), arcpy.env.scratchGDB))