Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SQLAlchemy 2.0, continued #275

Merged
merged 21 commits into from
Aug 3, 2023

Conversation

mhauru
Copy link
Contributor

@mhauru mhauru commented Aug 2, 2023

Continued from #249, see discussion there.

@coveralls
Copy link

coveralls commented Aug 2, 2023

Coverage Status

coverage: 97.655% (+0.2%) from 97.436% when pulling 7352912 on mhauru:sqlalchemy2 into 6ecfbc4 on agronholm:master.

@agronholm
Copy link
Owner

Thanks, I'll check this out later today.

Copy link
Owner

@agronholm agronholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code is good enough for merging. I'll do some tinkering on it later.
Aside from the suggestions I've added, I will still need an added changelog entry (remember to give credit to yourself and the author of the original PR).

.github/workflows/test.yml Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@mhauru
Copy link
Contributor Author

mhauru commented Aug 3, 2023

Tests fail on 3.12, but I made the other changes. Please edit the changelog entry to be to your liking.

@mhauru mhauru requested a review from agronholm August 3, 2023 10:23
@agronholm agronholm merged commit 66a88dc into agronholm:master Aug 3, 2023
13 checks passed
@agronholm
Copy link
Owner

Thanks a lot!

@mhauru
Copy link
Contributor Author

mhauru commented Aug 3, 2023

No problem, @rbuffat did all the actual work here. Do you plan to release this to pypi or do you want further changes before that?

@agronholm
Copy link
Owner

I think I will first tinker with the test suite and then release to PyPI later this week.

@agronholm
Copy link
Owner

What are you getting exactly?

@mhauru
Copy link
Contributor Author

mhauru commented Aug 24, 2023

Hi @agronholm, sorry to keep pestering you, I know you have competing priorities. Is there anything I can do to help in getting the SQLAlchemy 2 support into a PyPi release? It would unblock a series of dependency upgrades for our project.

@agronholm
Copy link
Owner

I wanted to fix a couple more bugs first, but looks like I didn't have the time. I've released v3.0.0rc3 now to unblock your upgrades.

@pang-thebasement
Copy link

Hello:
Thanks a lot to all contributors. I wanted to test sqlacodegen on our database, but when I try to pip install tag 3.0.0rc3

git checkout 3.0.0rc3
python3 -m pip install -U .

I get an error like this:

    Defaulting to user installation because normal site-packages is not writeable
    Processing /home/myuser/extra/software/sqlacodegen
      Installing build dependencies ... done
      Getting requirements to build wheel ... done
      Installing backend dependencies ... done
      Preparing metadata (pyproject.toml) ... done
    Building wheels for collected packages: UNKNOWN
      Building wheel for UNKNOWN (pyproject.toml) ... done
      Created wheel for UNKNOWN: filename=UNKNOWN-3.0.0rc3-py3-none-any.whl size=1867 sha256=d4d18a167a8f7c8f5c6a2bb9d8703aee259487e55336fc1e475998db872a5a99
      Stored in directory: /tmp/pip-ephem-wheel-cache-pj6osbkb/wheels/c5/88/d7/6594ab3afff35313f447a11f0f0dfe560bffee6b30ace33111
    Successfully built UNKNOWN
    Installing collected packages: UNKNOWN
    Successfully installed UNKNOWN-3.0.0rc3

After which there is a python package actually called UNKNOWN, which I can uninstall with python3 -m pip uninstall UNKNOWN
Sorry I can't help. The pyproject.toml looks fine to me. I haven't really used that format :-/

@agronholm
Copy link
Owner

Have you tried installing from the PyPI? pip install -U --pre sqlacodegen

@pang-thebasement
Copy link

Thanks, that works! And it gave in a blink some nice looking python code! Genius!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants