breaking change findWhere() now return to $this

agungsugiarto · Aug 25, 2020 · 7c38b48 · 7c38b48
1 parent cc90046
commit 7c38b48
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/Contracts/RepositoryInterface.php b/src/Contracts/RepositoryInterface.php
@@ -35,10 +35,9 @@ public function find($id, $columns = ['*']);
      * Add basic where clauses and execute the query.
      *
      * @param array $conditions
-     * @param array $columns
-     * @return array
+     * @return $this
      */
-    public function findWhere(array $conditions, array $columns = ['*']);
+    public function findWhere(array $conditions);
 
     /**
      * Paginate the given query.

diff --git a/src/Eloquent/BaseRepository.php b/src/Eloquent/BaseRepository.php
@@ -57,14 +57,15 @@ public function find($id, $columns = ['*'])
      * Add basic where clauses and execute the query.
      *
      * @param array $conditions
-     * @param array $columns
-     * @return array
+     * @return $this
      */
-    public function findWhere(array $conditions, array $columns = ['*'])
+    public function findWhere(array $conditions)
     {
-        return $this->withCriteria([
+        $this->withCriteria([
             new FindWhere($conditions)
-        ])->get($columns);
+        ]);
+
+        return $this;
     }
 
     /**