fix: swev-id: astropy__astropy-14539 handle FITSDiff Q VLAs#128
Open
casey-brooks wants to merge 1 commit intoastropy__astropy-14539from
Open
fix: swev-id: astropy__astropy-14539 handle FITSDiff Q VLAs#128casey-brooks wants to merge 1 commit intoastropy__astropy-14539from
casey-brooks wants to merge 1 commit intoastropy__astropy-14539from
Conversation
Author
|
Local test & lint results:
|
noa-lucent
approved these changes
Jan 6, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Looks good. Treating Q-format descriptors as VLAs in TableDataDiff resolves the false positives, and the new tests cover self-compare, delta-detect, mixed columns, and parity with P formats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #127.
Observed failure
Pdescriptors as VLA data, so row-wise differences went unreported.Reproduction
format="QE"column.FITSDiff(file_a, file_b, rtol=0, atol=0)—.identicalincorrectly returnsTrueand the report omits the column.Changes
TableDataDiffto treatQ-format descriptors as VLA columns alongsidePdescriptors.Testing
PYTHONPATH=. LD_LIBRARY_PATH='/nix/store/sbfrl6127w424l34lsq0lzryibq1226j-gcc-15.2.0/lib:/nix/store/h4qhxh7vwmxgy6w05g0xsf6r1bfi9vga-gcc-15.2.0-lib/lib:/nix/store/dvb9i3s69j29md1hpx3gpaqqds6530df-gcc-15.2.0-libgcc/lib:/nix/store/n5lymg0y5x6i9wipkjrsi8aczv1nr4qc-zlib-1.3.1/lib' SETUPTOOLS_USE_DISTUTILS=stdlib .venv/bin/python -m pytest astropy/io/fits/tests/test_diff.py -k vla_q(3 passed)PYTHONPATH=. LD_LIBRARY_PATH='/nix/store/sbfrl6127w424l34lsq0lzryibq1226j-gcc-15.2.0/lib:/nix/store/h4qhxh7vwmxgy6w05g0xsf6r1bfi9vga-gcc-15.2.0-lib/lib:/nix/store/dvb9i3s69j29md1hpx3gpaqqds6530df-gcc-15.2.0-libgcc/lib:/nix/store/n5lymg0y5x6i9wipkjrsi8aczv1nr4qc-zlib-1.3.1/lib' SETUPTOOLS_USE_DISTUTILS=stdlib .venv/bin/python -m pytest astropy/io/fits/tests/test_diff.py(52 passed)SETUPTOOLS_USE_DISTUTILS=stdlib .venv/bin/tox -e codestyle -- --files astropy/io/fits/diff.py astropy/io/fits/tests/test_diff.py(pass)