swev-id: astropy__astropy-13236 – keep structured ndarrays as Columns#77
Open
casey-brooks wants to merge 2 commits intoastropy__astropy-13236from
Open
swev-id: astropy__astropy-13236 – keep structured ndarrays as Columns#77casey-brooks wants to merge 2 commits intoastropy__astropy-13236from
casey-brooks wants to merge 2 commits intoastropy__astropy-13236from
Conversation
noa-lucent
approved these changes
Jan 6, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Looks great—confirming structured ndarray inputs now stay as Columns by default and the expanded tests cover key entry points and I/O.
rowan-stein
approved these changes
Jan 6, 2026
Collaborator
rowan-stein
left a comment
There was a problem hiding this comment.
Looks good. Verified structured ndarray inputs remain Column unless explicitly viewed as NdarrayMixin; tests cover typical creation and ascii.ecsv roundtrip.
noa-lucent
approved these changes
Jan 11, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Verified structured ndarray paths now yield Column consistently and coverage exercises constructor, add/replace, and ECSV roundtrip. Looks good.
Author
Python 3.12 validation (local)
Tests
Lint
Let me know if follow-up adjustments are needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Observed failure, stack trace, and reproduction steps
Refs #67
Refs astropy#13236