Skip to content

Comments

swev-id: astropy__astropy-13453 Fix HTML writer formatting handling#78

Open
casey-brooks wants to merge 1 commit intoastropy__astropy-13453from
casey/html-writer-formats-13453
Open

swev-id: astropy__astropy-13453 Fix HTML writer formatting handling#78
casey-brooks wants to merge 1 commit intoastropy__astropy-13453from
casey/html-writer-formats-13453

Conversation

@casey-brooks
Copy link

Summary

  • ensure the HTML writer applies configured column formats before output
  • preserve column formatting when expanding multidimensional cells
  • add regression tests for numeric, masked, quantity/mixin, and raw HTML columns

Testing

  • XDG_CONFIG_HOME=/workspace/.config LD_LIBRARY_PATH=/nix/store/wffgswxkp55xi14jy63rjsnfvl2qvmxy-gcc-14.3.0-lib/lib:$LD_LIBRARY_PATH /workspace/astropy/.venv/bin/python -m pytest --pyargs astropy.io.ascii.tests.test_html
  • .venv/bin/isort astropy/io/ascii/html.py astropy/io/ascii/tests/test_html.py
  • .venv/bin/pyupgrade --py38-plus astropy/io/ascii/html.py astropy/io/ascii/tests/test_html.py
  • .venv/bin/flake8 --count --select E101,W191,E201,E202,W291,W292,W293,W391,E111,E112,E113,E30,E502,E722,E901,E902,E999,F822,F823 astropy/io/ascii/html.py astropy/io/ascii/tests/test_html.py

Fixes #72

@casey-brooks
Copy link
Author

Local Validation

  • XDG_CONFIG_HOME=/workspace/.config LD_LIBRARY_PATH=/nix/store/wffgswxkp55xi14jy63rjsnfvl2qvmxy-gcc-14.3.0-lib/lib:$LD_LIBRARY_PATH /workspace/astropy/.venv/bin/python -m pytest --pyargs astropy.io.ascii.tests.test_html
  • .venv/bin/isort astropy/io/ascii/html.py astropy/io/ascii/tests/test_html.py
  • .venv/bin/pyupgrade --py38-plus astropy/io/ascii/html.py astropy/io/ascii/tests/test_html.py
  • .venv/bin/flake8 --count --select E101,W191,E201,E202,W291,W292,W293,W391,E111,E112,E113,E30,E502,E722,E901,E902,E999,F822,F823 astropy/io/ascii/html.py astropy/io/ascii/tests/test_html.py

Copy link

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@rowan-stein rowan-stein changed the title Fix HTML writer formatting handling swev-id: astropy__astropy-13453 Fix HTML writer formatting handling Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants