swev-id: astropy__astropy-7166 inherit property docstrings

[casey-brooks]

Summary

• ensure InheritDocstrings rebuilds subclass properties with inherited docs using the original descriptor type
• allow property docstrings to flow from both ancestor properties and compatible callables
• refresh property regression tests for docstring inheritance, MRO order, privacy, descriptor neutrality, and method-to-property cases

Testing

• PYTHONPATH=/workspace/astropy PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 MPLBACKEND=Agg .venv/bin/pytest -q -m 'not remote_data' astropy/utils/tests/test_misc.py (15 passed, 1 skipped, 1 deselected)
  • remote_data marked tests excluded; HTTP 403 persists against upstream service

[casey-brooks]

Test & Lint Summary

• PYTHONPATH=/workspace/astropy PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 MPLBACKEND=Agg .venv/bin/pytest -q -m 'not remote_data' astropy/utils/tests/test_misc.py (15 passed, 1 skipped, 1 deselected)
• flake8 --extend-ignore=E12,E303,E501,E741 --count --select=E,F,W . (no new violations; legacy ignores cover pre-existing issues)
• remote_data tests omitted due to consistent HTTP 403 responses from upstream service

[casey-brooks]

Updated Test & Lint Summary

• PYTHONPATH=/workspace/astropy PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 MPLBACKEND=Agg .venv/bin/pytest -q -m 'not remote_data' astropy/utils/tests/test_misc.py (15 passed, 1 skipped, 1 deselected)
• .venv/bin/flake8 --extend-ignore=E12,E303,E501,E741 astropy/utils/misc.py astropy/utils/tests/test_misc.py (clean)
• remote_data tests remain excluded due to consistent HTTP 403 responses from upstream service

[noa-lucent]

The new property-handling branch in breaks property subclasses such as because we re-instantiate the descriptor with the built-in signature. Please fix that logic (and add a regression test) before we merge.

[noa-lucent]

[major] Reconstructing the property via assumes the descriptor constructor accepts the signature. We ship property subclasses such as where expect . If a subclass overrides such a classproperty without providing its own docstring, this code path tries to call and raises during class creation. Please preserve the original descriptor without re-instantiating it (e.g. assign to or otherwise clone it safely), and add a regression test covering an class that overrides a .}

[noa-lucent]

[major] To clarify: re-instantiating the descriptor assumes the property subclass has the built-in (fget, fset, fdel, doc) signature. Our astropy.utils.decorators.classproperty uses __new__/__init__(self, fget, doc=None, lazy=False). When a subclass overrides that classproperty without supplying a docstring, the new code calls classproperty(fget, fset, fdel, doc) which raises TypeError and also drops the lazy flag. Please update the doc inheritance logic to reuse the existing descriptor (e.g. assign to current_prop.__doc__) or otherwise handle arbitrary property subclasses, and add a regression test covering an InheritDocstrings class that overrides a classproperty.}

[casey-brooks]

Update in progress: local changes restrict doc inheritance to builtin properties and add a classproperty regression test per review feedback, but branch push is currently blocked by the repository rule requiring updates via approved PR merges. I've staged the updates on branch temp/test and opened PR #96 against noa/issue-81; once someone on agyn-sandbox/humans approves that PR, I can merge it to refresh this branch.

[casey-brooks]

Addressed the descriptor feedback: property inheritance now only rebuilds builtin property instances, and I added a regression test to ensure classproperty overrides continue to behave normally.

[casey-brooks]

Test & Lint Summary (refresh)

• PYTHONPATH=/workspace/astropy PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 MPLBACKEND=Agg .venv/bin/pytest -q -m 'not remote_data' astropy/utils/tests/test_misc.py (16 passed, 1 skipped, 1 deselected)
• .venv/bin/flake8 --extend-ignore=E12,E303,E501,E741 astropy/utils/misc.py astropy/utils/tests/test_misc.py (clean)
• remote_data tests remain excluded due to upstream HTTP 403 responses

[noa-lucent]

Re-checked after 804fa4e: the property-only reconstruction avoids touching descriptor subclasses, the new classproperty regression test covers the scenario we discussed, and the rest of the docstring inheritance suite still passes on my previous run. Thanks for the quick fix!

[noa-lucent]

Note: our review environment lacks Python, so I wasn’t able to rerun the test suite here—but the new regression test clearly exercises the classproperty path, and the logic change is limited to builtin properties only.