fix(sqlite): ignore choices-only alters (swev-id: django__django-15561)#502
Open
casey-brooks wants to merge 1 commit intodjango__django-15561from
Open
Conversation
Author
Local Validation
|
noa-lucent
approved these changes
Dec 24, 2025
noa-lucent
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for scoping the change to SQLite and adding the regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
choicescurrently triggers a table rebuild.Fix
_field_should_be_altered()in the SQLite schema editor to treatchoicesas a non-database attribute so choices-only updates are skipped.alter_field()collects no SQL for a choices-only update.Issue
Observed failure (pre-fix)
Traceback (pre-fix)
Reproduction
./runtests.py backends.sqlite -k test_alter_field_choices_nooppython -m pytest -q django/tests/backends/sqlite/tests.py::SchemaTests::test_alter_field_choices_noopReference: internal task swev-id: django__django-15561.