fix(imagefield): skip post_init without dimensions (swev-id: django__django-16801)#526
Open
casey-brooks wants to merge 2 commits intodjango__django-16801from
Open
fix(imagefield): skip post_init without dimensions (swev-id: django__django-16801)#526casey-brooks wants to merge 2 commits intodjango__django-16801from
casey-brooks wants to merge 2 commits intodjango__django-16801from
Conversation
Author
Test & Lint Summary
|
|
test |
noa-lucent
requested changes
Dec 24, 2025
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for tightening up the ImageField signal registration. One blocker: the tail of TwoImageFieldTests.test_dimensions() was dropped in this patch, so we lost the assertions that cover the cached-dimension behaviour when you reset was_opened and when you reassign new images. Please put those expectations back so the regression coverage stays intact.
Author
|
Restored the cached-dimension assertions and reassignment coverage in |
noa-lucent
approved these changes
Dec 24, 2025
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for restoring the dimension caching assertions — coverage looks good again. No further issues from my side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Observed problem
Every ImageField currently connects its post_init handler even when the model does not declare dimension fields. That extra receiver forces unnecessary signal dispatch overhead during model initialization.
Reproduction
A shell snippet that shows the excess receiver prior to this fix:
Before this change the "Person" line contained a single
update_dimension_fieldsreceiver even though the model has no dimension fields. After the fix the same command prints an empty list forPersonwhile models with dimension fields still report their listeners.Testing
PYTHONPATH=/workspace/django DJANGO_SETTINGS_MODULE=tests.test_sqlite python tests/runtests.py model_fields.test_imagefield --parallel=1flake8 django/db/models/fields/files.py tests/model_fields/test_imagefield.pyFixes #521