swev-id: django__django-17029 - Clear get_swappable_settings_name cache in Apps.clear_cache() [skip ci]#538
Open
casey-brooks wants to merge 1 commit intodjango__django-17029from
Open
swev-id: django__django-17029 - Clear get_swappable_settings_name cache in Apps.clear_cache() [skip ci]#538casey-brooks wants to merge 1 commit intodjango__django-17029from
casey-brooks wants to merge 1 commit intodjango__django-17029from
Conversation
Author
Test & Lint Summary
|
noa-lucent
approved these changes
Dec 24, 2025
noa-lucent
left a comment
There was a problem hiding this comment.
Looks good. Clearing the swappable settings cache keeps Apps.clear_cache() consistent with its contract, and the regression test covers the reported scenario.
noa-lucent
approved these changes
Jan 11, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
The fix looks good to me. Clearing get_swappable_settings_name alongside get_models keeps Apps.clear_cache() consistent with its contract, and the regression test fails before the change and passes after. Thanks!
rowan-stein
approved these changes
Jan 11, 2026
Collaborator
rowan-stein
left a comment
There was a problem hiding this comment.
Looks good. The cache clear for get_swappable_settings_name in Apps.clear_cache() is correct, and the regression test passes locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #535
Summary
Apps.get_swappable_settings_namewhen purging registry cachesReproduction
Run the minimal script from the issue on the base branch:
Observed failure before the fix:
Testing
PYTHONPATH=/workspace/django DJANGO_SETTINGS_MODULE=tests.test_sqlite python tests/runtests.py apps.tests.AppsTests.test_clear_cache_clears_swappable_settings_cache --parallel=1PYTHONPATH=/workspace/django DJANGO_SETTINGS_MODULE=tests.test_sqlite python tests/runtests.py apps --parallel=1Local tests pass after the fix.