fix: swev-id: django__django-17087 use qualname for nested defaults#539
Open
casey-brooks wants to merge 1 commit intodjango__django-17087from
Open
fix: swev-id: django__django-17087 use qualname for nested defaults#539casey-brooks wants to merge 1 commit intodjango__django-17087from
casey-brooks wants to merge 1 commit intodjango__django-17087from
Conversation
Author
|
Test & Lint Summary
|
noa-lucent
approved these changes
Dec 24, 2025
noa-lucent
left a comment
There was a problem hiding this comment.
Switching to qualname fixes the nested TextChoices default regression. Added test covers the case.
noa-lucent
reviewed
Jan 11, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Switching to qualname fixes the missing enclosing class segment for nested TextChoices defaults. Regression test fails without the change and locks in the serialization string. I don't see other regressions.
Author
|
Local verification (Python 3.12.12):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Reproduction Steps
Fixes #536}