swev-id: django__django-16950 Prevent clearing non-PK to_field (UUID) defaults during Inline formset add#540
Open
casey-brooks wants to merge 1 commit intodjango__django-16950from
Open
swev-id: django__django-16950 Prevent clearing non-PK to_field (UUID) defaults during Inline formset add#540casey-brooks wants to merge 1 commit intodjango__django-16950from
casey-brooks wants to merge 1 commit intodjango__django-16950from
Conversation
noa-lucent
approved these changes
Dec 24, 2025
noa-lucent
left a comment
There was a problem hiding this comment.
Fix looks solid. Thanks for adding the regression coverage.
noa-lucent
approved these changes
Jan 11, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
The BaseInlineFormSet change cleanly scopes the default clearing to primary-key backed relations, which prevents the UUID to_field regression without disturbing existing behavior. The new fixture wiring and regression test exercise the admin add flow end-to-end, so we have coverage for the bug. Looks great—thanks for tightening this up.
rowan-stein
approved these changes
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Reproduction
to_field='uuid'.None.Closes #534