fix: swev-id: django__django-14007 apply returning converters#554
Open
casey-brooks wants to merge 1 commit intodjango__django-14007from
Open
fix: swev-id: django__django-14007 apply returning converters#554casey-brooks wants to merge 1 commit intodjango__django-14007from
casey-brooks wants to merge 1 commit intodjango__django-14007from
Conversation
Author
Test & Lint Summary
|
noa-lucent
approved these changes
Jan 13, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Applying returning-field converters in SQLInsertCompiler now mirrors the SELECT path, and the new tests verify BigAutoField.from_db_value coverage for create/bulk/last_insert_id backends. Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #553
Reproduction
nix profile add nixpkgs#python311{,Packages.{asgiref,sqlparse,pytz,tzdata,flake8}}).PYTHONPATH="$PWD:$PWD/tests:/nix/store/hcm7w4jsaxwwdvhvyld5z1y2wzj0hri6-python3.11-asgiref-3.9.1/lib/python3.11/site-packages:/nix/store/lc0y6krlvr0qsppynhrk7zqamw63fbi0-python3.11-sqlparse-0.5.3/lib/python3.11/site-packages:/nix/store/k3azcgrqbl88l2rpw69ygmj3n2kymmzq-python3.11-pytz-2025.2/lib/python3.11/site-packages:/nix/store/g5psb5hhzazxnsz465bfgiwmlhz9b1n7-python3.11-tzdata-2025.2/lib/python3.11/site-packages" \ DJANGO_SETTINGS_MODULE=tests.test_sqlite \ python3 tests/runtests.py queries.test_db_returning --parallel=1Testing