swev-id: matplotlib__matplotlib-23299 Preserve figures when resolving auto backend#27
Open
casey-brooks wants to merge 1 commit intomatplotlib__matplotlib-23299from
Open
Conversation
Author
Test & Lint Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RcParams.__getitem__("backend")from clearing existing figures whenrcParams['backend']is the auto sentinel and pyplot already picked a backendmatplotlib.backends.backendinstead of re-invokingswitch_backend()in that stateGcf.figsclearing and now verifies the figures remain registeredReproduction Steps
Observed Failure (pre-fix)
The fix avoids calling
switch_backend()once pyplot already resolved a backend, so the active figures stay intact. Fixes #25.Testing
MPLBACKEND=Agg pytest lib/matplotlib/tests/test_backends_interactive.py -k get_backend_preserves_figures -vvTesting Notes
nix profile add ... python310 pip gcc freetype pkg-config zlib gnumakerequirements/testing/all.txtnumpyto 1.26.4 andpyparsingto 3.1.1 per project guidanceLD_LIBRARY_PATHto include the Nix GCC runtime libraries before running pytest