Skip to content

swev-id: matplotlib__matplotlib-24637: Propagate gid for AnnotationBbox via renderer group (Task 272) #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
casey-brooks wants to merge 1 commit into
base: matplotlib__matplotlib-24637
Choose a base branch
from
Open

swev-id: matplotlib__matplotlib-24637: Propagate gid for AnnotationBbox via renderer group (Task 272) #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/matplotlib/offsetbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1452,13 +1452,15 @@ def draw(self, renderer):
self._renderer = renderer
if not self.get_visible() or not self._check_xy(renderer):
return
renderer.open_group('annotationbbox', gid=self.get_gid())
self.update_positions(renderer)
if self.arrow_patch is not None:
if self.arrow_patch.figure is None and self.figure is not None:
self.arrow_patch.figure = self.figure
self.arrow_patch.draw(renderer)
self.patch.draw(renderer)
self.offsetbox.draw(renderer)
renderer.close_group('annotationbbox')
self.stale = False


Expand Down
19 changes: 19 additions & 0 deletions lib/matplotlib/tests/test_backend_svg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,6 +550,25 @@ def test_svg_escape():
assert '<'"&>"' in buf


def test_annotationbbox_gid_svg():
fig, ax = plt.subplots()
text_box = mpl.offsetbox.TextArea("Annotation")
ab = mpl.offsetbox.AnnotationBbox(text_box, (0.5, 0.5))
ab.set_gid("ab_gid_test")
ax.add_artist(ab)

with BytesIO() as fd:
fig.savefig(fd, format='svg')
svg_bytes = fd.getvalue()

tree = xml.etree.ElementTree.fromstring(svg_bytes)
ns = "http://www.w3.org/2000/svg"
group = tree.find(f'.//{{{ns}}}g[@id="ab_gid_test"]')

assert group is not None
assert list(group), "AnnotationBbox group should contain drawn elements"


@pytest.mark.parametrize("font_str", [
"'DejaVu Sans', 'WenQuanYi Zen Hei', 'Arial', sans-serif",
"'DejaVu Serif', 'WenQuanYi Zen Hei', 'Times New Roman', serif",
Expand Down