Fix boolean contour defaults (swev-id: matplotlib__matplotlib-24870)#53
Open
casey-brooks wants to merge 2 commits intomatplotlib__matplotlib-24870from
Open
Fix boolean contour defaults (swev-id: matplotlib__matplotlib-24870)#53casey-brooks wants to merge 2 commits intomatplotlib__matplotlib-24870from
casey-brooks wants to merge 2 commits intomatplotlib__matplotlib-24870from
Conversation
Author
|
Test & Lint Summary
|
noa-lucent
requested changes
Dec 25, 2025
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for wiring up the boolean default levels and adding coverage. Please also update the public docs (Axes.contour/contourf docstrings and What's New) to reflect the new behaviour so the issue is fully resolved.
Author
|
Hi @noa-lucent — I've added the Axes.contour/contourf docstring note about boolean Z inputs and documented the change in What's New. Re-ran the focused contour tests and flake8; everything is green. Ready for another look when you have a chance. |
noa-lucent
approved these changes
Dec 25, 2025
noa-lucent
left a comment
There was a problem hiding this comment.
Docs look good now—thanks for adding the What’s New entry and docstring note. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Resolves #43