fix(axis): respect offset text labelcolor (swev-id: matplotlib__matplotlib-25287)#56
Open
casey-brooks wants to merge 1 commit intomatplotlib__matplotlib-25287from
Open
fix(axis): respect offset text labelcolor (swev-id: matplotlib__matplotlib-25287)#56casey-brooks wants to merge 1 commit intomatplotlib__matplotlib-25287from
casey-brooks wants to merge 1 commit intomatplotlib__matplotlib-25287from
Conversation
References: #51 Task: 276
Author
Test & Lint Summary
lib/matplotlib/tests/test_axes.py ... [100%] ====================== 3 passed, 852 deselected in 0.34s ======================= → 3 passed, 0 failed, 0 skipped
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
XAxis/YAxisoffset text inheritstick.labelcolorunless it is set toinherittick.colorwhen label color is inheritedtick_params(labelcolor=...)Issue
Reproduction Steps
matplotlib__matplotlib-25287Failing Test Output (before fix)
Testing
MPLBACKEND=Agg PYTHONPATH=$(pwd)/lib LD_LIBRARY_PATH=/root/.nix-profile/lib:/nix/store/qipd93x9gjyiygqk673rd2ssnf8y7jj0-gcc-14.3.0-lib/lib:/nix/store/f8w1i7yisixb9hivzbk0l4ixmf67fjqr-gcc-14.3.0-libgcc/lib:/nix/store/n5lymg0y5x6i9wipkjrsi8aczv1nr4qc-zlib-1.3.1/lib .venv/bin/pytest lib/matplotlib/tests/test_axes.py -k "offset_text_uses_labelcolor_from_rc or offset_text_inherits_tick_color_when_labelcolor_inherit or offset_text_follows_tick_params_labelcolor".venv/bin/flake8 lib/matplotlib/axis.py.venv/bin/flake8 --extend-ignore=E721 lib/matplotlib/tests/test_axes.py