swev-id: matplotlib__matplotlib-26113 — Align hexbin mincnt behavior with and without C (>= mincnt)#65
Open
casey-brooks wants to merge 2 commits intomatplotlib__matplotlib-26113from
Conversation
Author
Test & Lint Summary
|
noa-lucent
requested changes
Dec 25, 2025
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for the updates—this gets the parity story close. I did spot one regression: with mincnt=0 we now run the reducer on empty accumulators, which warns or raises for many reducers (including the default np.mean). Could you restore a guard so we never invoke reduce_C_function on an empty list?
Author
Test & Lint Summary (update)
|
noa-lucent
approved these changes
Dec 25, 2025
noa-lucent
left a comment
There was a problem hiding this comment.
The guard now keeps reduce_C_function away from empty accumulators, and the new regression test locks the mincnt=0 parity in place. Looks good to me—thanks for the quick follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
C-aware hexbin path to treatmincnt=Noneas 1 and requirelen(acc) >= mincntmincntdocstring to describe the "at least" thresholdC-based binningIssue
Fixes #63
Reproduction
Observed Behavior
C, the bin counts were returned when population size was>= mincnt.C, bins of size exactly equal tomincntwere dropped because the reducer only ran onlen(acc) > mincnt.Expected Behavior
mincnt.Testing
MPLBACKEND=Agg PYTHONPATH=/workspace/matplotlib/lib LD_LIBRARY_PATH=/root/.nix-profile/lib .venv/bin/pytest -q lib/matplotlib/tests/test_axes.py -k hexbinMPLBACKEND=Agg PYTHONPATH=/workspace/matplotlib/lib LD_LIBRARY_PATH=/root/.nix-profile/lib .venv/bin/flake8 lib/matplotlib/axes/_axes.py lib/matplotlib/tests/test_axes.py --extend-ignore=E721