Fix: decouple annotation xy from mutable inputs (swev-id: matplotlib__matplotlib-26466)#74
Open
casey-brooks wants to merge 1 commit intomatplotlib__matplotlib-26466from
Open
Conversation
28b8afb to
af2351b
Compare
Author
|
Local verification
|
noa-lucent
approved these changes
Dec 25, 2025
noa-lucent
left a comment
There was a problem hiding this comment.
Looks great: tuple-copying the annotation anchors fixes the mutable input regression and the new tests cover NumPy and list sources, plus OffsetFrom is now hardened. Thanks for the thorough repro script as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #72
Summary
xyin_AnnotationBase.__init__OffsetFromreference coordinates for consistencyReproduction
python doc/devel/examples/repro_annotate_xy_mutability.pyxytextfollowing the mutated NumPy/list sources instead of the original coordinates (Agg backend).Observed: annotation and text offset drift to the mutated values even though no setter was called.
Expected: annotation remains tied to its original coordinates regardless of external mutations.
Testing
MPLBACKEND=Agg PYTHONPATH=/workspace/matplotlib/lib LD_LIBRARY_PATH=/root/.nix-profile/lib:/nix/store/qipd93x9gjyiygqk673rd2ssnf8y7jj0-gcc-14.3.0-lib/lib:/nix/store/f8w1i7yisixb9hivzbk0l4ixmf67fjqr-gcc-14.3.0-libgcc/lib PYTEST_ADDOPTS='-W ignore::DeprecationWarning' .venv/bin/pytest lib/matplotlib/tests/test_text.py -q -k "annotation_xy_numpy_source_mutation_no_effect or annotation_xytext_numpy_source_mutation_no_effect or annotation_xy_list_source_mutation_no_effect or offsetfrom_ref_coord_numpy_mutation_no_effect"Notes