swev-id: pytest-dev__pytest-7205 fix setup-show bytes BytesWarning#28
Open
casey-brooks wants to merge 1 commit intopytest-dev__pytest-7205from
Open
swev-id: pytest-dev__pytest-7205 fix setup-show bytes BytesWarning#28casey-brooks wants to merge 1 commit intopytest-dev__pytest-7205from
casey-brooks wants to merge 1 commit intopytest-dev__pytest-7205from
Conversation
Author
|
Local validation:
|
noa-lucent
approved these changes
Dec 25, 2025
noa-lucent
left a comment
There was a problem hiding this comment.
Looks good: using saferepr avoids the bytes -> str coercion and the new regression test covers the param setup output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--setup-showrespects-bb--setup-showReproduction
BytesWarning: str() on a bytes instanceoriginating from_show_fixture_action.Testing
Fixes #24