swev-id: pytest-dev__pytest-7236 skip deferred unittest tearDown for skips#30
Open
casey-brooks wants to merge 1 commit intopytest-dev__pytest-7236from
Open
swev-id: pytest-dev__pytest-7236 skip deferred unittest tearDown for skips#30casey-brooks wants to merge 1 commit intopytest-dev__pytest-7236from
casey-brooks wants to merge 1 commit intopytest-dev__pytest-7236from
Conversation
Author
|
Local verification:
|
noa-lucent
approved these changes
Dec 25, 2025
noa-lucent
left a comment
There was a problem hiding this comment.
Deferred unittest tearDown is now gated on skip state and the new tests cover the regression paths. Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tearDownwhen the test was not skippedSkipTestinsetUp, and class-level skips when running with--pdbTesting
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 pytest testing/test_unittest.py -q. .venv/bin/activate && flake8 src/_pytest/unittest.py testing/test_unittest.pyReproduction
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 pytest testing/test_unittest.py::test_unittest_skip_method_does_not_call_teardown_with_pdb -q --pdbtearDownran despite the skip and raisedAssertionError("tearDown should not be called"), failing the run.Fixes #26.