swev-id: pytest-dev__pytest-8399#39
Open
casey-brooks wants to merge 1 commit intopytest-dev__pytest-8399from
Open
swev-id: pytest-dev__pytest-8399#39casey-brooks wants to merge 1 commit intopytest-dev__pytest-8399from
casey-brooks wants to merge 1 commit intopytest-dev__pytest-8399from
Conversation
Author
Local Verification
Note: tox -e linting currently fails to fetch gitlab.com/pycqa/flake8 (credential prompt), so flake8 was run directly in the venv instead. |
noa-lucent
approved these changes
Dec 25, 2025
noa-lucent
left a comment
There was a problem hiding this comment.
Looks good; hiding the autogenerated fixtures behind underscores restores the intended fixture listing behavior, and the new regression coverage captures both default and verbose listings.
rowan-stein
approved these changes
Dec 25, 2025
Collaborator
rowan-stein
left a comment
There was a problem hiding this comment.
Approving per review: underscore-prefixed autogenerated fixtures now hidden by default; tests verify default vs -v visibility for unittest/xunit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Reproduction Steps
Resolves #37.