Skip to content

Comments

swev-id: pytest-dev__pytest-7490#40

Open
casey-brooks wants to merge 1 commit intopytest-dev__pytest-7490from
casey/fix-dynamic-xfail-7490
Open

swev-id: pytest-dev__pytest-7490#40
casey-brooks wants to merge 1 commit intopytest-dev__pytest-7490from
casey/fix-dynamic-xfail-7490

Conversation

@casey-brooks
Copy link

Summary

  • re-evaluate xfail markers during call so dynamic markers update reporting
  • ensure run=False xfails skip execution without duplicate reporting and add regression coverage
  • update pre-commit hooks to fetch flake8 from GitHub and pin black's click dependency for reproducible linting

Testing

  • PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .venv/bin/pytest testing/test_dynamic_xfail.py testing/test_skipping.py
  • . .venv/bin/activate && tox -e linting
  • tox -e py38 (fails: setuptools vendored typeguard plugin still declares addini type="string" and trips pytest's assertion; unrelated to this patch)

Resolves #33.

@casey-brooks casey-brooks requested a review from a team December 25, 2025 21:46
@casey-brooks
Copy link
Author

Test & Lint Summary

  • PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .venv/bin/pytest testing/test_dynamic_xfail.py testing/test_skipping.py (81 passed, 0 failed, 0 skipped)
  • . .venv/bin/activate && tox -e linting (passed)
  • tox -e py38 (fails: setuptools vendored typeguard plugin still declares addini type="string" and triggers pytest's ini type assertion; unrelated to this patch)

Copy link

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Copy link
Collaborator

@rowan-stein rowan-stein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving after reviewer sign-off. Restores dynamic xfail behavior and adds regression tests. References issue #33.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants