swev-id: pytest-dev__pytest-7982

[casey-brooks]

Summary

• ensure directory traversal follows symlinks without infinite loops
• add regression coverage for symlinked directory arguments and subdirectories

Testing

• before fix: PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .venv/bin/pytest repro/tests -> collected 0 items
• after fix: PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .venv/bin/pytest repro/tests -> 1 passed
• PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .venv/bin/pytest testing/test_collection.py::test_collect_symlinked_directory_argument testing/test_collection.py::test_collect_symlinked_subdirectory
• .venv/bin/black --check src/_pytest/pathlib.py testing/test_collection.py
• .venv/bin/flake8 src/_pytest/pathlib.py testing/test_collection.py

Fixes #41

[casey-brooks]

Test & Lint Summary

• `PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .venv/bin/pytest repro/tests` → 1 passed
• `PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .venv/bin/pytest testing/test_collection.py::test_collect_symlinked_directory_argument testing/test_collection.py::test_collect_symlinked_subdirectory` → 2 passed
• `.venv/bin/black --check src/_pytest/pathlib.py testing/test_collection.py` → no changes
• `.venv/bin/flake8 src/_pytest/pathlib.py testing/test_collection.py` → clean

`tox -e linting` is not reachable here because pre-commit cannot fetch https://gitlab.com/pycqa/flake8 without credentials; the manual black/flake8 runs above cover the linted files.

[noa-lucent]

Thanks for tackling the symlink regression and adding focused coverage. One issue remains: the new traversal logic now swallows every that arises from , which means permission errors or other unexpected filesystem failures get muted instead of surfacing. Please narrow that handler to the errno cases we actually expect (e.g. broken links, ELOOP) and let other errors propagate so we don’t hide real problems.

[casey-brooks]

Retested after tightening the errno handling:

• PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .venv/bin/pytest testing/test_collection.py::test_collect_symlinked_directory_argument testing/test_collection.py::test_collect_symlinked_subdirectory → 2 passed
• .venv/bin/flake8 src/_pytest/pathlib.py → clean

[noa-lucent]

Thanks for tightening up the exception handling—limiting it to the expected errno cases keeps traversal robust without muting real errors. The added regression tests exercise both direct invocation and parent directory traversal, so the original issue is covered. LGTM.