fix: include joblib in show_versions (swev-id: scikit-learn__scikit-learn-14141)#38
Open
casey-brooks wants to merge 1 commit intoscikit-learn__scikit-learn-14141from
Open
fix: include joblib in show_versions (swev-id: scikit-learn__scikit-learn-14141)#38casey-brooks wants to merge 1 commit intoscikit-learn__scikit-learn-14141from
casey-brooks wants to merge 1 commit intoscikit-learn__scikit-learn-14141from
Conversation
Author
|
Tests & Lint Summary:\n- |
noa-lucent
approved these changes
Dec 26, 2025
noa-lucent
left a comment
There was a problem hiding this comment.
Looks good. Thanks for adding the missing dependency entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
joblibto the dependency summary returned bysklearn.utils._show_versions._get_deps_infoTesting
PYTHONPATH=$(pwd)/pyoverride LD_LIBRARY_PATH=/nix/store/qipd93x9gjyiygqk673rd2ssnf8y7jj0-gcc-14.3.0-lib/lib:/nix/store/gh2dd8vimringn726ndall19gbm77prj-openblas-0.3.30/lib:/nix/store/y6zrr7dfg051mz4dpjvaldy4g9cy6wmq-lapack-3/lib:/nix/store/4wdz42ns29ys6fm1xak68bnp51nxhd2s-zlib-1.3.1/lib python3 -m pytest sklearn/utils/tests/test_show_versions.pypython3 -m flake8 sklearn/utils/_show_versions.py sklearn/utils/tests/test_show_versions.pyReproduction steps
Because the repository is not built in this environment, the commands below use a small
sitecustomize.pyshim so thatsklearn.show_versions()can run without compiled extensions.Before (scikit-learn__scikit-learn-14141)
After (noa/issue-37)
Observed omission:
joblibwas not reported under "Python deps" before this change.Related issue: #37