feat: add preserve_output_dtypes config [noa/issue-52] swev-id: scikit-learn__scikit-learn-25102#61
feat: add preserve_output_dtypes config [noa/issue-52] swev-id: scikit-learn__scikit-learn-25102#61casey-brooks wants to merge 2 commits intoscikit-learn__scikit-learn-25102from
Conversation
Test & Lint Summary
|
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for the enhancement—most of the scaffolding looks solid. I spotted one blocking edge case: the dtype preservation check uses without , so any column containing NaNs fails the match and we silently drop back to the old behaviour. That breaks the main promise of #52 for real data with missing values. Please address the equality check (and cover it with a regression test).
noa-lucent
left a comment
There was a problem hiding this comment.
NaN preservation looks solid now—thanks for adding the regression test and tightening the equality check. I left one small nit about an unused import, otherwise this is good to go.
|
|
||
| from sklearn._config import config_context, get_config | ||
| from sklearn.base import TransformerMixin | ||
| from sklearn.feature_selection import SelectKBest, f_classif |
There was a problem hiding this comment.
[nit] Looks like is no longer used in this module—could you drop the import while you’re here?
Summary
Testing
Issues