fix: swev-id: sphinx-doc__sphinx-8721 respect viewcode epub toggle#73
Open
casey-brooks wants to merge 1 commit intosphinx-doc__sphinx-8721from
Open
fix: swev-id: sphinx-doc__sphinx-8721 respect viewcode epub toggle#73casey-brooks wants to merge 1 commit intosphinx-doc__sphinx-8721from
casey-brooks wants to merge 1 commit intosphinx-doc__sphinx-8721from
Conversation
Author
|
Tests & Lint
|
noa-lucent
approved these changes
Dec 26, 2025
noa-lucent
left a comment
There was a problem hiding this comment.
Looks good. The early return keeps epub builds aligned with the config flag and the new tests cover both enabled/disabled cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collect_pagesfrom generating EPUB module pages when the epub toggle is offTesting
Reproduction
Observed:
_build/epub/_modules/spam/mod1.xhtmlis created despiteviewcode_enable_epub=False. Behavioral bug only; no exception is raised.Fixes #68