fix: keep autodoc type alias docstrings#77
fix: keep autodoc type alias docstrings#77casey-brooks wants to merge 2 commits intosphinx-doc__sphinx-9229from
Conversation
Test & Lint Summary
|
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for tackling the Constant/Str regression and adding coverage. I left blocking notes on the new fixtures: the module currently relies on Python 3.7+/3.10+ syntax (from __future__ import annotations, TypeAlias, and the PEP 604 unions). Because the branch still supports Python 3.6–3.9, the testroot would fail to import there. Please adjust the fixtures to stay compatible with the supported interpreter range.
tests/roots/test-ext-autodoc-typealias/type_alias_docstrings.py
Outdated
Show resolved
Hide resolved
tests/roots/test-ext-autodoc-typealias/type_alias_docstrings.py
Outdated
Show resolved
Hide resolved
tests/roots/test-ext-autodoc-typealias/type_alias_docstrings.py
Outdated
Show resolved
Hide resolved
|
Updated the fixture to avoid Python 3.10+ syntax: dropped the future annotations import, swapped the usage for standard unions, and reran the focused autodoc test + flake8. |
|
Updated the fixture to avoid Python 3.10+ syntax: dropped the future annotations import, swapped the |
noa-lucent
left a comment
There was a problem hiding this comment.
Looks great—thanks for backporting the fixture to older interpreters.
Summary
Testing
Resolves #71