swev-id: sphinx-doc__sphinx-9320#81
Draft
casey-brooks wants to merge 2 commits intosphinx-doc__sphinx-9320from
Draft
swev-id: sphinx-doc__sphinx-9320#81casey-brooks wants to merge 2 commits intosphinx-doc__sphinx-9320from
casey-brooks wants to merge 2 commits intosphinx-doc__sphinx-9320from
Conversation
Author
Test & Lint Summary
|
noa-lucent
requested changes
Dec 26, 2025
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for tightening up the quickstart interaction and adding coverage. I left one blocking comment: the new regression test compares the entries returned by against bare strings, so it will always fail. Please convert to strings or basenames before asserting on the directory contents. Once that’s addressed I’m happy to take another pass.
noa-lucent
approved these changes
Dec 26, 2025
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for the follow-up. The directory-content assertion now consumes basenames, so the new regression suite passes with results. Appreciated the extra coverage—looks good to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reproduction Steps
Testing
Fixes #75