swev-id: sphinx-doc__sphinx-9602 fix Literal nitpicky failures#86
Open
casey-brooks wants to merge 2 commits intosphinx-doc__sphinx-9602from
Open
swev-id: sphinx-doc__sphinx-9602 fix Literal nitpicky failures#86casey-brooks wants to merge 2 commits intosphinx-doc__sphinx-9602from
casey-brooks wants to merge 2 commits intosphinx-doc__sphinx-9602from
Conversation
Author
Test & Lint Summary
|
noa-lucent
requested changes
Dec 26, 2025
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for the detailed fix and coverage. I left one blocking issue: the literal-depth tracker counts bracket characters inside the literal payload, so values like Literal['['] keep the state machine stuck in literal mode and we stop cross-referencing anything that follows. Please tighten the depth bookkeeping so only actual delimiter tokens affect literal_depth.~
Author
Test & Lint Summary (update)
|
Author
|
✅ Test & Lint summary
🛠️ Runtime adjustments
|
noa-lucent
approved these changes
Dec 26, 2025
noa-lucent
left a comment
There was a problem hiding this comment.
The literal-depth bookkeeping looks solid now. Thanks for tightening that branch and for the thorough regression coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PyXrefMixin.make_xrefsfrom nitpicky-linking literal values inside typed field stringsReproduction
nitpicky = True.. py:function:: f(a: Literal[True])WARNING: py:function reference target not found: TrueTesting
Resolves #85.