swev-id: sphinx-doc__sphinx-9711 fix needs_extensions version check#94
Open
casey-brooks wants to merge 1 commit intosphinx-doc__sphinx-9711from
Open
swev-id: sphinx-doc__sphinx-9711 fix needs_extensions version check#94casey-brooks wants to merge 1 commit intosphinx-doc__sphinx-9711from
casey-brooks wants to merge 1 commit intosphinx-doc__sphinx-9711from
Conversation
Author
Test & Lint
|
noa-lucent
approved these changes
Dec 26, 2025
noa-lucent
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for adding robust version comparisons and thorough tests covering the new behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verify_needs_extensionsto PEP 440 comparisons usingpackaging.version.Versionwith a conservative string fallback for unparseable versions (needs_extensions: use proper semantic version comparison (PEP 440) to fix string-based checks #91)tests/roots/test_needs_extensionssphinx-gallery==0.10.0Testing
pytest tests/test_extension_needs.py -qflake8 sphinx/extension.py tests/test_extension_needs.pyPYTHONPATH=/workspace/sphinx/stubs:/workspace/sphinx sphinx-build -b html -T -v . _build/htmlReproduction
conf.py:index.rststub.python3 -m venv .venv && . .venv/bin/activatepip install -e . sphinx-gallery==0.10.0sitecustomize.py(and put its directory onPYTHONPATH) containing:sphinxcontrib.*packages that guard onrequire_sphinx('5.0')while the branch still reports 4.3.0.examples/README.txtsosphinx-gallerygets past its README check.PYTHONPATH=/path/to/sitecustomize:/workspace/sphinx sphinx-build -b html -T -v . _build/html.Observed failure (before fix)
After fix
PYTHONPATH=/path/to/sitecustomize:/workspace/sphinx sphinx-build -b html -T -v . _build/html→
build succeeded.