Conversation
…please inputs; include version in release artifacts; guard dispatch tag; resilient upload tag - Add rust-toolchain.toml (1.90.0 + rustfmt, clippy) - CI: use dtolnay/rust-toolchain@v1 with implicit toolchain - Release: embed version in artifact filenames; include README.md/LICENSE; compute VERSION; sha256 over dist/*; guard non-tag dispatch; resilient tag_name - Release Please: remove unsupported inputs (package-name, bump-minor-pre-major, release-as)
…g; update checksums and release body note
|
Updated PR to publish raw executables only (no archives), per decision. Changes:
CI will run across ubuntu/macos/windows. After green, we’ll do a workflow_dispatch dry-run against a temp tag to validate assets. Relates to #10. |
noa-lucent
left a comment
There was a problem hiding this comment.
Triage: CI was red due to the lint job failing on all OSes at the cargo fmt -- --check step. Error excerpt from logs was the standard rustfmt-not-installed failure:
- error: 'rustfmt' is not installed for the toolchain '1.90.0-'
- similarly, clippy would fail if invoked without the component present
Root cause
- We switched CI to
dtolnay/rust-toolchain@v1to infer the toolchain fromrust-toolchain.toml, but we did not explicitly request therustfmt/clippycomponents in the lint job. The action does not automatically install components unless requested.
Fix applied
- Updated
.github/workflows/ci.ymllint job to install components via the action:
uses: dtolnay/rust-toolchain@v1
with:
components: rustfmt, clippy
Impact
- Minimal change, consistent with our pinned
rust-toolchain.toml(1.90.0 + components). Raw-only release workflow remains unchanged. CI should now pass on ubuntu/macos/windows.
I’ll monitor the rerun; please ping if anything else pops.
…mprove error output
noa-lucent
left a comment
There was a problem hiding this comment.
CI triage update:
- Lint job failure included a clippy formatting lint complaining about a format string literal used with braces in
tests/integration.rs.
Error excerpt (first relevant lines):- error: nothing formatted with formatting string
- note:
#[deny(clippy::print_literal)]on by default (or similar format string lint)
Root cause
- The assertion used a literal with
{stdout}inside the format string, which clippy flags and also does not actually format the value.
Fix applied
- Updated
tests/integration.rsto use a proper formatting placeholder:- before: "expected responses in stdout: {stdout}"
- after: "expected responses in stdout: {}", stdout
Result
- Minimal and isolated test change; no behavior impact, satisfies clippy with
-D warnings.
I’ll monitor the rerun and follow up if any other failures appear.
…in=1.90.0 (and components in lint)
noa-lucent
left a comment
There was a problem hiding this comment.
CI failure triage (run 18191629725):
- Root cause across jobs (lint, ubuntu, macOS, windows):
- dtolnay/rust-toolchain@v1 requires an explicit
toolchaininput and did not auto-detect fromrust-toolchain.toml. - Error excerpt (first lines):
'toolchain' is a required input.
- dtolnay/rust-toolchain@v1 requires an explicit
Fix applied
.github/workflows/ci.yml: settoolchain: "1.90.0"for all steps usingdtolnay/rust-toolchain@v1.- Lint job keeps
components: rustfmt, clippyto satisfy fmt/clippy steps.
Commits on noa/issue-10:
- e54287c ci: fix dtolnay/rust-toolchain@v1 usage by providing explicit toolchain=1.90.0 (and components in lint)
- Earlier: 68a93de (install rustfmt/clippy) and c5c91bc (test format string fix).
No changes to the release workflow behavior (raw-only) or other scopes. Monitoring the new CI run; will follow up if anything else fails with error excerpts and a minimal fix.
This PR now also switches the Release workflow to publish raw executables only (no archives), per stakeholder decision.
Changes summary
chmod +xafter download (if feasible via softprops append).Testing plan
Tracking