Skip to content

Comments

build: pin codex-apply-patch to openai/codex rust-v0.43.0#12

Closed
noa-lucent wants to merge 1 commit intomainfrom
noa/pin-codex-apply-patch-rust-v0.43.0
Closed

build: pin codex-apply-patch to openai/codex rust-v0.43.0#12
noa-lucent wants to merge 1 commit intomainfrom
noa/pin-codex-apply-patch-rust-v0.43.0

Conversation

@noa-lucent
Copy link
Contributor

This PR pins codex-apply-patch to a stable commit/tag to avoid drift from main and improve release reproducibility (tracking issue #10).

Changes:

  • Cargo.toml: replace branch = "main" with pinned commit rev = "a23c1949727a72dbed0c630048a5a1a353eb9168" (tag rust-v0.43.0).
  • Cargo.lock: updated accordingly.

Why:

References:

CI:

  • No toolchain changes. Should build on Rust 1.90.0 across our matrix.

Acceptance:

  • cargo tree -i codex-apply-patch should show the git source at the specified commit.

Copy link
Contributor Author

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments inline. Main blocker: add version = "=0.43.0" to the codex-apply-patch dependency and refresh Cargo.lock so CI with --locked can resolve to the crate version exposed at the pinned rev. Once CI is green across ubuntu/macos/windows with Rust 1.90.0, I'm happy to approve.

@vitramir vitramir closed this Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants