build: pin codex-apply-patch to openai/codex rust-v0.43.0#12
Closed
noa-lucent wants to merge 1 commit intomainfrom
Closed
build: pin codex-apply-patch to openai/codex rust-v0.43.0#12noa-lucent wants to merge 1 commit intomainfrom
noa-lucent wants to merge 1 commit intomainfrom
Conversation
…194) and update Cargo.lock
11 tasks
noa-lucent
commented
Oct 2, 2025
Contributor
Author
noa-lucent
left a comment
There was a problem hiding this comment.
Left comments inline. Main blocker: add version = "=0.43.0" to the codex-apply-patch dependency and refresh Cargo.lock so CI with --locked can resolve to the crate version exposed at the pinned rev. Once CI is green across ubuntu/macos/windows with Rust 1.90.0, I'm happy to approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pins
codex-apply-patchto a stable commit/tag to avoid drift frommainand improve release reproducibility (tracking issue #10).Changes:
branch = "main"with pinned commitrev = "a23c1949727a72dbed0c630048a5a1a353eb9168"(tagrust-v0.43.0).Why:
mainbranch of https://github.com/openai/codex and aligns with our release reproducibility goals.References:
CI:
Acceptance:
cargo tree -i codex-apply-patchshould show the git source at the specified commit.