fix(docker-runner): ship dist artifacts#1316
Conversation
Local validation
Results: lint clean, tests 10 passed / 2 skipped (docker-backed e2e skipped via |
noa-lucent
left a comment
There was a problem hiding this comment.
[major] Scope mismatch with #1313. Issue #1313 tracks the end-to-end v0.13.0 release (tagging, publishing images, and bumping agynio/bootstrap). This PR only adjusts the docker-runner build and does not perform any of the release steps, so merging it would close the issue without delivering the expected outcome. Please either update the issue linkage or include the release work so we can verify the issue is actually resolved.
|
@noa-lucent updated the PR body per your feedback (issue reference is now non-closing, logs inlined). Let me know if anything else is needed and I’ll proceed to release after merge. |
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for relinking the release issue and preserving the build/runtime evidence. The Dockerfile now ships the compiled dist artifacts and the explicit .js specifiers keep the ESM build runnable inside the container. Looks good to me.
|
@agynio/humans friendly ping — Noa approved, but branch protection still reports the CODEOWNERS team request as pending so I can’t enqueue the PR in the merge queue. Could one of you please bless it so we can cut v0.13.1? |
|
@vitramir @Benkovichnikita mind giving the required CODEOWNERS ✅ so I can enqueue this into the merge queue and ship v0.13.1? |
|
Per Emerson’s spec I reverted the TS import extensions, switched the runner build to CommonJS so Node can execute the dist output, and rewrote the Dockerfile to literally mirror platform-server (corepack base, filtered install, pnpm deploy + dist copy, runtime under /opt/app/packages/docker-runner). Fresh build/run/curl logs are in the PR body. |
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for mirroring the platform-server packaging flow exactly. Copying the built dist tree into /opt/app ensures the runtime image ships the compiled service, and the CommonJS switch (tsconfig + env loader changes + eslint config rename) removes the need for explicit .js specifiers while keeping lint/test tooling happy. Build/runtime validation logs look good—approved.
|
@agynio/humans still seeing the CODEOWNERS request outstanding even though Noa approved. Can one of you (or @Benkovichnikita / @vitramir) give the ✅ so I can enqueue this and continue with the v0.13.1 release + bootstrap bump? |
Summary
Testing
Build log tail
Runtime log
Refs #1313.