-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gh14] jump links #54
Open
ahaywood
wants to merge
6
commits into
main
Choose a base branch
from
feature/gh14-jump-links
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0a08be0
✨Time Jumps from the URL are working
ahaywood de552bb
✨ Time Jump links working
ahaywood 8ef6484
🐛 Updated dependencies
ahaywood 2b95eee
🙈 Updates
ahaywood a0321f9
Pulled from master. Got jump links to work. Able to parse timestamp i…
jamesqquick 28bb777
Removed logs
jamesqquick File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
export const config = { | ||
/** | ||
* Find your project ID and dataset in `sanity.json` in your studio project. | ||
* These are considered “public”, but you can use environment variables | ||
* if you want differ between local dev and production. | ||
* | ||
* https://nextjs.org/docs/basic-features/environment-variables | ||
* */ | ||
dataset: process.env.NEXT_PUBLIC_SANITY_DATASET || 'production', | ||
projectId: process.env.NEXT_PUBLIC_SANITY_PROJECT_ID, | ||
apiVersion: '2021-03-25', | ||
/** | ||
* Set useCdn to `false` if your application require the freshest possible | ||
* data always (potentially slightly slower and a bit more expensive). | ||
* Authenticated request (like preview) will always bypass the CDN | ||
* */ | ||
useCdn: process.env.NODE_ENV === 'production', | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
// lib/sanity.js | ||
import { | ||
createImageUrlBuilder, | ||
createPortableTextComponent, | ||
createPreviewSubscriptionHook, | ||
createCurrentUserHook, | ||
} from 'next-sanity'; | ||
import { config } from './config'; | ||
|
||
/** | ||
* Set up a helper function for generating Image URLs with only the asset reference data in your documents. | ||
* Read more: https://www.sanity.io/docs/image-url | ||
* */ | ||
export const urlFor = (source) => createImageUrlBuilder(config).image(source); | ||
|
||
// Set up the live preview subscription hook | ||
export const usePreviewSubscription = createPreviewSubscriptionHook(config); | ||
|
||
// Set up Portable Text serialization | ||
export const PortableText = createPortableTextComponent({ | ||
...config, | ||
// Serializers passed to @sanity/block-content-to-react | ||
// (https://github.com/sanity-io/block-content-to-react) | ||
serializers: {}, | ||
}); | ||
|
||
// Helper function for using the current logged in user account | ||
export const useCurrentUser = createCurrentUserHook(config); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
// lib/sanity.server.js | ||
import { createClient } from 'next-sanity'; | ||
import { config } from './config'; | ||
|
||
// Set up the client for fetching data in the getProps page functions | ||
export const sanityClient = createClient(config); | ||
|
||
// Set up a preview client with serverless authentication for drafts | ||
export const previewClient = createClient({ | ||
...config, | ||
useCdn: false, | ||
token: process.env.SANITY_API_TOKEN, | ||
}); | ||
|
||
// Helper function for easily switching between normal client and preview client | ||
export const getClient = (usePreview) => (usePreview ? previewClient : sanityClient); | ||
|
||
// taken from: https://github.com/vercel/next.js/blob/canary/examples/cms-sanity/lib/sanity.server.js | ||
export function overlayDrafts(docs) { | ||
const documents = docs || []; | ||
const overlayed = documents.reduce((map, doc) => { | ||
if (!doc._id) { | ||
throw new Error('Ensure that `_id` is included in query projection'); | ||
} | ||
|
||
const isDraft = doc._id.startsWith('drafts.'); | ||
const id = isDraft ? doc._id.slice(7) : doc._id; | ||
return isDraft || !map.has(id) ? map.set(id, doc) : map; | ||
}, new Map()); | ||
|
||
return Array.from(overlayed.values()); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
import { useState, useRef } from 'react'; | ||
import { useState, useRef, useEffect } from 'react'; | ||
|
||
export const useAudioPlayer = (audioRef, progressBarRef) => { | ||
const [speed, setSpeed] = useState(1); | ||
|
@@ -9,10 +9,16 @@ export const useAudioPlayer = (audioRef, progressBarRef) => { | |
|
||
const onLoadedMetadata = () => { | ||
const seconds = Math.floor(audioRef.current.duration); | ||
setDuration(seconds); | ||
progressBarRef.current.max = seconds; | ||
if (!Number.isNaN(seconds)) { | ||
setDuration(seconds); | ||
progressBarRef.current.max = seconds; | ||
} | ||
}; | ||
|
||
useEffect(() => { | ||
onLoadedMetadata(); | ||
}, [audioRef?.current?.loadedmetadata, audioRef?.current?.readyState]); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The I actually just learned this from James' optional chaining video |
||
|
||
// when the playhead is moved, update the current time (text) | ||
const updateCurrentTime = () => { | ||
setCurrentTime(progressBarRef.current.value); | ||
|
@@ -112,9 +118,11 @@ export const useAudioPlayer = (audioRef, progressBarRef) => { | |
timeTravel(Number(progressBarRef.current.value) + 30); | ||
}; | ||
|
||
const skipToTime = (newTime) => { | ||
const skipToTime = (newTime, autoPlay) => { | ||
timeTravel(newTime); | ||
play(); | ||
if (autoPlay) { | ||
play(); | ||
} | ||
}; | ||
|
||
// toggle play / pause when you tap the space bar | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to list out what I have changed.
This should be 0 not null