Merge pull request #48 from khaitu/mangle-properties-global-fix

Mangle Properties Fix
ahorek · Nov 27, 2023 · 6888b3f · 6888b3f
2 parents 636421c + 21c41bd
commit 6888b3f
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 42 deletions.
diff --git a/lib/terser_wrapper.js b/lib/terser_wrapper.js
@@ -1,6 +1,8 @@
 // Set source-map.js sourceMap to terser.js MOZ_SourceMap
 MOZ_SourceMap = sourceMap;
 
+var global = global || {};
+
 function comments(option) {
   if (Object.prototype.toString.call(option) === '[object Array]') {
     return new RegExp(option[0], option[1]);

diff --git a/spec/terser_spec.rb b/spec/terser_spec.rb
@@ -46,48 +46,47 @@
     expect(Terser.new.compile('var foo="\0bar"')).to include("\\0bar")
   end
 
-  # TODO: fixme
-  #  describe "property name mangling" do
-  #    let(:source) do
-  #      <<-JS
-  #       var obj = {
-  #          _hidden: false,
-  #          "quoted": 'value'
-  #        };
-  #
-  #        alert(object.quoted);
-  #      JS
-  #    end
-  #
-  #    it "does not mangle property names by default" do
-  #      expect(Terser.compile(source)).to include("object.quoted")
-  #    end
-  #
-  #    it "can be configured to mangle properties" do
-  #      expect(Terser.compile(source, :mangle => { :properties => true }))
-  #        .not_to include("object.quoted")
-  #    end
-  #
-  #    it "can be configured using old mangle_properties" do
-  #      expect(Terser.compile(source, :mangle_properties => true))
-  #        .not_to include("object.quoted")
-  #    end
-  #
-  #    it "can configure a regex for mangling" do
-  #      expect(Terser.compile(source, :mangle => { :properties => { :regex => /^_/ } }))
-  #        .to include("object.quoted")
-  #    end
-  #
-  #    it "can be configured to keep quoted properties" do
-  #      expect(Terser.compile(source, :mangle => { :properties => { :keep_quoted => true } }))
-  #        .to include("object.quoted")
-  #    end
-  #
-  #    it "can be configured to include debug in mangled properties" do
-  #      expect(Terser.compile(source, :mangle => { :properties => { :debug => true } }))
-  #        .to include("_$quoted$_")
-  #    end
-  #  end
+  describe "property name mangling" do
+    let(:source) do
+      <<-JS
+       var obj = {
+          _hidden: false,
+          "quoted": 'value'
+        };
+
+        alert(object.quoted);
+      JS
+    end
+
+    it "does not mangle property names by default" do
+      expect(Terser.compile(source)).to include("object.quoted")
+    end
+
+    it "can be configured to mangle properties" do
+      expect(Terser.compile(source, :mangle => { :properties => true }))
+        .not_to include("object.quoted")
+    end
+
+    it "can be configured using old mangle_properties" do
+      expect(Terser.compile(source, :mangle_properties => true))
+        .not_to include("object.quoted")
+    end
+
+    it "can configure a regex for mangling" do
+      expect(Terser.compile(source, :mangle => { :properties => { :regex => /^_/ } }))
+        .to include("object.quoted")
+    end
+
+    it "can be configured to keep quoted properties" do
+      expect(Terser.compile(source, :mangle => { :properties => { :keep_quoted => true } }))
+        .to include("object.quoted")
+    end
+
+    it "can be configured to include debug in mangled properties" do
+      expect(Terser.compile(source, :mangle => { :properties => { :debug => true } }))
+        .to include("_$quoted$_")
+    end
+  end
 
   describe "argument name mangling" do
     let(:code) { "function bar(foo) {return foo + 'bar'};" }