component + discovery #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ComponentDescriptor -> Instance - Make Typed Entity fields private, only way to construct is through instance - remove validation from type entities, to exist they must be valid.
| /// Represents a validated namespace hierarchy with runtime context | ||
| #[derive(Debug, Clone)] | ||
| pub struct Namespace { | ||
| hierarchy: String, |
There was a problem hiding this comment.
Can you explain a bit more about this new namespace hierarchy concept. Below we have
hierarchy: self.namespace.clone(),Not sure what the purpose is
- introduce Identity trait which relies on Instance, allows every Typed Struct to give their Identity - in addition to DiscoveryKV and DiscoveryPlane add EtcdIdentity and PathExtension traits. - EtcdIdentity relies on Identity and provides a translation between Identity format and etcd format. - PathExtension traits allows us to create Paths object from components that can then be used as keys to access etcd.
|
Could we just say that things have a name? The name is a string. That's it. Remove namespace/component/endpoint, delete this PR. Things have a name. I don't understand the point of this enhancement. It sounds clever and complicated and unnecessary. Maybe a couple of concrete examples would help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.