-
Notifications
You must be signed in to change notification settings - Fork 161
DEVICE/API: Change addresses to offsets and add channel_id #815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
michal-shalev
merged 24 commits into
ai-dynamo:main
from
michal-shalev:device-api-changes
Oct 7, 2025
Merged
DEVICE/API: Change addresses to offsets and add channel_id #815
michal-shalev
merged 24 commits into
ai-dynamo:main
from
michal-shalev:device-api-changes
Oct 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Shalev <mshalev@nvidia.com>
👋 Hi michal-shalev! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
Signed-off-by: Michal Shalev <mshalev@nvidia.com>
itayalroy
reviewed
Sep 22, 2025
This PR is missing a change to nixlGpuSignal:
should be changed to:
|
Signed-off-by: Michal Shalev <mshalev@nvidia.com>
Signed-off-by: Michal Shalev <mshalev@nvidia.com>
Signed-off-by: Michal Shalev <mshalev@nvidia.com>
ofirfarjun7
approved these changes
Oct 6, 2025
/build |
rakhmets
reviewed
Oct 6, 2025
itayalroy
approved these changes
Oct 6, 2025
brminich
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Implement support for passing local and remote addresses to UCX device memory lists, enabling GPU-initiated transfers with pre-configured address pairs and offset-based operations, and add channel ID to the APIs.
Why?
Improve user experience by allowing GPU kernels to work with simple offsets relative to pre-configured base addresses, rather than requiring users to manage and pass absolute addresses for every transfer operation.
Adding channel ID to the device APIs would enable pre-resolved QP/channel selection at runtime, allowing users to register memory once for all experts and then dynamically choose the correct channel during execution, which reduces connection setup time and initialization overhead.
How?
createGpuXferReq
to accept local memory objects, remote rkeys, and remote addressesgetBase()
method tonixlUcxMem
to access local addressesgetSize()
method tonixlUcxMem
to access descriptor sizecreateGpuXferReq
implementation to populatelocal_addr
andremote_addr
fields in UCX memory list elementschannel_id
to NIXL device APIs