Added func. for collecting variables with partial scope match. #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This looks good. I don't think I have any changes (was going to say something about comments, but the others in this don't have them), but please add tests at: https://github.com/aiUIUC/pyAIUtils/blob/master/tests/test_tftools.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added function for collecting variables that contain the given name_scope in their scope hierarchy without having to give the complete scope hierarchy.
Eg. If var in input var_type collection has var.name = 'scope1/scope2/scope3/var_name:4'
Then name_scope='scope2' will collect this variable instead of having to give scope1/scope2 has input.
Also if scope_i, scope_n, scope_m all contain scope2 within it, collecting all variables of scope_2 requires multiple calls to existing functions. With this it can be done with one call.