Tidy up functional tests

aido · Nov 17, 2023 · 05b78c8 · 05b78c8
1 parent 5e500c7
commit 05b78c8
Show file tree

Hide file tree

Showing 14 changed files with 3,107 additions and 3,125 deletions.
diff --git a/README.md b/README.md
@@ -28,7 +28,7 @@ When the seed is validated, the user can create [Shamir's secret sharing (SSS)](
 The application uses [Sharded Secret Key Reconstruction (SSKR)](https://github.com/BlockchainCommons/Research/blob/master/papers/bcr-2020-011-sskr.md), an interoperable implementation of [Shamir's Secret Sharing (SSS)](https://en.wikipedia.org/wiki/Shamir%27s_secret_sharing). This provides a way for you to divide or 'shard' the master seed underlying a Bitcoin HD wallet into 'shares', which you can then distribute to friends, family, or fiduciaries. If you lose your seed, you can reconstruct it by collecting a sufficient number of your shares (the 'threshold'). Knowledge of fewer than the required number of parts ensures that information about the master secret is not leaked.
 
 * SSKR is round-trip compatible with BIP-39.
-* SSKR based on SLIP-39, developed by SatoshiLabs. It is an improvement on, but is incompatible with, SLIP-39.
+* SSKR is based on SLIP-39, developed by SatoshiLabs. It is an improvement on, but is incompatible with, SLIP-39.
 * SSKR phrases use a dictionary of exactly 256 English words with a uniform word size of 4 letters.
 * SSKR encodes a [CBOR] structure tagged with the data type [URTYPES], and is therefore self-describing.
 * Phrases generated by SSKR can be up to 46 words in length i.e. 184 characters.

diff --git a/src/main.c b/src/main.c
@@ -153,7 +153,6 @@ __attribute__((section(".boot"))) int main(void) {
     BEGIN_TRY {
         TRY {
             io_seproxyhal_init();
-            // ui_idle();
             ui_idle_init();
             sample_main();
         }

diff --git a/src/nano/nanos_enter_phrase.c b/src/nano/nanos_enter_phrase.c
@@ -331,19 +331,6 @@ const bagl_element_t* screen_onboarding_restore_word_keyboard_callback(unsigned
                 } else {
                     G_ux.string_buffer[0] = '_';
                 }
-                // will never occur on word stem, autocomplete always happen before that
-                // else {
-                //   // first char is '...' to notify continuing
-                //   if (value == 0) {
-                //     G_ux.string_buffer[0] = '.';
-                //     G_ux.string_buffer[1] = '.';
-                //     G_ux.string_buffer[2] = '.';
-                //     G_ux.string_buffer[3] = 0;
-                //   }
-                //   else {
-                //     G_ux.string_buffer[0] = (G_ux.string_buffer+16+l+1-8)[value];
-                //   }
-                // }
                 break;
             }
             return NULL;
@@ -672,8 +659,6 @@ unsigned int screen_onboarding_restore_word_select_button(unsigned int button_ma
                         G_bolos_ux_context.sskr_words_buffer_length--;
                     }
                 }
-                // log_debug(G_bolos_ux_context.words_buffer);
-
                 // clear previous word
                 screen_onboarding_restore_word_init(RESTORE_WORD_ACTION_REENTER_WORD);
             }

diff --git a/src/nano/nanox_enter_phrase.c b/src/nano/nanox_enter_phrase.c
@@ -337,7 +337,6 @@ const bagl_element_t* screen_onboarding_restore_word_keyboard_callback(unsigned
                 G_ux.tmp_element.component.x +=
                     1 + G_ux.tmp_element.component.width / 2 - C_icon_backspace.width / 2;
                 G_ux.tmp_element.component.y -= 7;
-                // G_ux.tmp_element.component.y = 5;
                 G_ux.tmp_element.component.height = C_icon_backspace.height;
                 G_ux.tmp_element.component.type = BAGL_ICON;
                 G_ux.tmp_element.component.icon_id = 0;
@@ -461,8 +460,6 @@ const bagl_element_t* screen_onboarding_restore_word_before_element_display_call
 }
 
 static uint8_t compare_recovery_phrase(void) {
-    // io_seproxyhal_general_status();
-
     // convert mnemonic to hex-seed
     uint8_t buffer[64] = {0};
     if (G_bolos_ux_context.onboarding_type == ONBOARDING_TYPE_BIP39) {

diff --git a/src/nano/ux_nano.h b/src/nano/ux_nano.h
@@ -18,11 +18,6 @@
 
 #include "ux_common/common.h"
 
-/*
-#if defined(TARGET_NANOS)
-#define ARRAYLEN(array) (sizeof(array) / sizeof(array[0]))
-#endif
-*/
 #if defined(TARGET_NANOS)
 #define BIP39_ICON                         C_bip39_nanos
 #define SSKR_ICON                          C_sskr_nanos