Merge pull request #7 from aido/montgomery_constant

Changed Second Montgomery constant to a more suitable value

CHANGELOG.md

@@ -1,200 +1,196 @@
-# Change log
+# Changelog
 
-## [1.7.2] - 2024-05-06
-### Added
--
+All notable changes to this project will be documented in this file.
 
-### Changed
--
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
+and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+## [1.7.3] - 2024-05-29
 
 ### Fixed
-- Using Ledger SDK `cx_crc32()` function rather than buggy `cx_crc32_hw()`.
+- Changed name of 'Generate BIP39' menus to 'Recover BIP39'
+- Changed Second Montgomery constant used for `cx_bn_gf2_n_mul()` to a more suitable value
+- Improve efficiency of `cx_bn_gf2_n_mul()` for Nano S
+- Change cmocka git repo from cryptomilk.org to GitLab
 
+## [1.7.2] - 2024-05-06
+
+### Fixed
+
+- Using Ledger SDK `cx_crc32()` function rather than buggy `cx_crc32_hw()`.
+- Fix build with SDK master for Nano S
 
 ## [1.7.1] - 2024-03-06
-### Added
--
 
 ### Changed
-- Improve efficiency of SSS `interpolate()` function
 
-### Fixed
--
+- Improve efficiency of SSS `interpolate()` function
 
 ## [1.7.0] - 2024-03-03
+
 ### Added
+
 - Added detailed documentation for all SSKR and SSS functions
 
 ### Changed
+
 - Changed Shamir interpolate function to use `cx_bn_gf2_n_mul()` syscalls
 - Changed some function names to be more descriptive
 - Reorganised and renamed some of the SSKR and Shamir code
 
-### Fixed
--
-
 ## [1.6.1] - 2024-01-27
+
 ### Added
+
 - Added a Release Policy document
 
 ### Changed
+
 - Updated version of cmocka used for unit tests
 - Updated version of github actions used
 - Assert HMAC return values
 
 ### Fixed
+
 - Fixed failing Ledger rule enforcer check
 - Use `cx_crc32_hw()`
   - Ledger have fixed their buggy implementation of CRC32 so we can start using it again
 
 ## [1.6.0] - 2024-01-14
+
 ### Added
+
 - Use CX_CHECK macro in `compare_recovery_phrase()`
 - Added a `cx_crc32()` function
   - The implementation of `cx_crc32_hw()` on Ledger devices is buggy and produces incorrect CRC32 checks. Ledger are fixing `cx_crc32_hw()` on each device either through SDK or OS updates but until then `cx_crc32()` can be used.
 
-### Changed
--
-
-### Fixed
--
-
 ## [1.5.4] - 2023-11-30
+
 ### Added
+
 - Added mandatory Ledger embedded application manifest file
 
 ### Changed
-- Combined BIP39 wordlist and SSKR wordlist unit tests
 
-### Fixed
--
+- Combined BIP39 wordlist and SSKR wordlist unit tests
 
 ## [1.5.3] - 2023-11-18
+
 ### Added
+
 - Added unit tests for BIP39
 - Added unit tests for BIP39 word list and SSKR word list
 
-### Changed
--
-
 ### Fixed
+
 - Fixed CodeQL warnings about sign check of a bitwise operation
 - Fixed issue with restarting input from a previous word on Nano S
 
 ## [1.5.2] - 2023-11-15
-### Added
--
 
 ### Changed
+
 - Save memory by setting the SSKR word buffer to a sensible size
   - There is just enough memory available on Nano S to hold the phrases for 10 shares. Other devices can hold the full 16 shares.
 - Tidied up code that sets 'Processing' screen on Nano S devices
+
+### Security
+
 - Changed all Variable Length Arrays to a defined length
 
 ### Fixed
+
 - Fix freezing at 'Processing' screen on Nano S devices
 
 ## [1.5.1] - 2023-11-09
+
 ### Added
+
 - Added unit tests for shamir
 - Added unit tests for SSKR
 - Added unit tests for BIP39 <-> SSKR roundtrip
 
 ### Changed
-- Reduce size of Nano binaries slightly by removing duplicate flows
+
 - Make generic SSKR functionality more Ledger specific
 
-### Fixed
--
+### Removed
+
+- Reduce size of Nano binaries slightly by removing duplicate flows
 
 ## [1.5.0] - 2023-10-20
+
 ### Added
-- Added option to generate BIP39 mnemonics from SSKR shares even if shares do not validate against seed on device
-  - A user may have lost or damaged original device and now needs to generate the recovery phrase from another secure device
 
-### Changed
--
+- Added option to recover BIP39 mnemonics from SSKR shares even if shares do not validate against seed on device
+  - A user may have lost or damaged original device and now needs to recover the BIP39 phrase from another secure device
 
 ### Fixed
+
 - Fixed build warning about UNUSED macro
 
 ## [1.4.1] - 2023-10-13
-### Added
-- Clear buffers before exiting
 
-### Changed
--
+### Security
 
-### Fixed
--
+- Clear buffers before exiting
 
 ## [1.4.0] - 2023-05-14
+
 ### Added
-- Added BIP39 Check for Ledger Stax
 
-### Changed
--
+- Added BIP39 Check for Ledger Stax
 
 ### Fixed
+
 - Fixed warnings about deprecated functions during build
 
 ## [1.3.2] - 2023-05-08
+
 ### Added
+
 - Added some Ledger specific preprocessor conditionals to bc-sskr and bc-shamir
 
 ### Changed
-- Changed memset(x, 0, y) to memzero(x, y) macro
 
-### Fixed
--
+- Changed memset(x, 0, y) to memzero(x, y) macro
 
 ## [1.3.1] - 2023-05-03
-### Added
--
-
-### Changed
--
 
 ### Fixed
+
 - Fixed static analyzer warning about zero-length array
 - Fixed CodeQL warnings about comparison of narrow type with wide type in loop condition
 
 ## [1.3.0] - 2023-04-27
-### Added
--
 
 ### Changed
-- Removed duplicated nano code
+
 - Simplified flow code
 
-### Fixed
--
+### Removed
+
+- Removed duplicated nano code
 
 ## [1.2.0] - 2023-04-21
+
 ### Added
+
 - Added automated tests
 - Added flow to set SSKR threshold values
 
-### Changed
--
-
-### Fixed
--
-
 ## [1.1.1] - 2023-04-06
-### Added
--
-
-### Changed
--
 
 ### Fixed
+
 - Fix issue with using 'cx_crc32_hw()' function in 'onboarding_seed_sskr.c' when testing with Speculos
 - Some CodeQL suggested tidy ups
 
 ## [1.1.0] - 2023-04-04
+
 ### Added
-- Generate BIP39 mnemonic phrases from SSKR shares
+
+- Recover BIP39 mnemonic phrases from SSKR shares
   - Add 'SSKR Check' menu option
   - Add flow to the 'SSKR Check' menu
   - Write SSKR to BIP39 functionality
@@ -204,15 +200,10 @@
   - Test on nanosp
   - Test on nanox
 
-### Changed
--
-
-### Fixed
--
-
 ## [1.0.1] - 2023-03-21
 
 ### Added
+
 - Clone app-recovery-check and rename to app-sskr-check
 - Add SSKR (bc-sskr and bc-shamir) to app-sskr-check
 - Generate SSKR shares from BIP39 mnemonic phrase
@@ -224,9 +215,3 @@
   - Test on nanos
   - Test on nanosp
   - Test on nanox
-
-### Changed
--
-
-### Fixed
--

Makefile

@@ -28,7 +28,7 @@ all: default
 APPNAME = "Seed Tool"
 APPVERSION_M = 1
 APPVERSION_N = 7
-APPVERSION_P = 2
+APPVERSION_P = 3
 APPVERSION   = "$(APPVERSION_M).$(APPVERSION_N).$(APPVERSION_P)"
 
 APP_LOAD_PARAMS = --appFlags 0x10 $(COMMON_LOAD_PARAMS) --curve secp256k1 --path ""