Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple MacOS X uses CPU timers #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hasseily
Copy link

Updated iagp to use CPU timers for Mac OSX

@aiekick
Copy link
Owner

aiekick commented Jul 17, 2024

thanks for this work.

but :

  • we must propose CPU or GPU profiling accessible via a menu in the IAGP frame.
  • for those who not have GL_ARB_timer_query just displayed the CPU

so not a conf specific to APPLE, juste a test to check the support of the extention GL_ARB_timer_query and make available CPU/GPU or just CPU

@hasseily
Copy link
Author

Ok but figuring out if GL_ARB_timer_query exists is GLEW/GLAD dependent I think. Which creates more problems.
What we could do is look for start and/or end times of zero. That would clearly show that glQueryCounter is failing, and revert to a CPU version.

@aiekick
Copy link
Owner

aiekick commented Jul 17, 2024

yes and since its GLEW/GLAD dependent, we must provide a function for that to define in the config file like the function for get/make current gl context.

CPU profiling is not gpu profiling.
Its not the same thing.

So use the CPU when we cant have the GPU can be needed in some case with warning logged, but not only for apple, as the maintainer of this lib i need the full workaround. and this is when the user not have the query counter. its maybe possible to have this support for some version of macos; or specific use case i dont have in mind foe the moment. this behavioru can be maybe on other platforms.re

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants